Pass time constant to bwe smoothing filter.

webrtc/voice_engine/channel.cc

Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index a7df1f2176ce5ade86669c8295c461758f9a9b2b..09f3a9262ac6bd7822e0efd8fc7acad2ee1fe68a 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -1301,7 +1301,7 @@ int32_t Channel::SetSendCodec(const CodecInst& codec) {
   return 0;
 }
 
-void Channel::SetBitRate(int bitrate_bps) {
+void Channel::SetBitRate(int bitrate_bps, int64_t probing_interval_ms) {
   WEBRTC_TRACE(kTraceInfo, kTraceVoice, VoEId(_instanceId, _channelId),
                "Channel::SetBitRate(bitrate_bps=%d)", bitrate_bps);
   audio_coding_->ModifyEncoder([&](std::unique_ptr<AudioEncoder>* encoder) {
@@ -1312,10 +1312,15 @@ void Channel::SetBitRate(int bitrate_bps) {
 
   // We give smoothed bitrate allocation to audio network adaptor as
   // the uplink bandwidth.
-  // TODO(michaelt) : Remove kDefaultBitrateSmoothingTimeConstantMs as soon as
-  // we pass the probing interval to this function.
-  constexpr int64_t kDefaultBitrateSmoothingTimeConstantMs = 20000;
-  bitrate_smoother_.SetTimeConstantMs(kDefaultBitrateSmoothingTimeConstantMs);
+  // The probing spikes should not affect the bitrate smoother more than 25%.
+  // To simplify the calculations we use a step response as input signal.
+  // The step response of an exponential filter is
+  // u(t) = 1 - e^(-t / time_constant).
+  // In order to limit the affect of a BWE spike within 25% of its value before
+  // the next probing, we would choose a time constant that fulfills
+  // 1 - e^(-probing_interval / time_constant) < 0.25

[minyue-webrtc, 2016/11/28 13:14:43]

probing_interval -> probing_interval_ms to be consistent with context. (sorry
for being not careful enough in my suggested text)

[michaelt, 2016/11/28 13:30:09]

Done.

+  // Then 4 * probing_interval is a good choice.
+  bitrate_smoother_.SetTimeConstantMs(probing_interval_ms * 4);
   bitrate_smoother_.AddSample(bitrate_bps);
   audio_coding_->ModifyEncoder([&](std::unique_ptr<AudioEncoder>* encoder) {
     if (*encoder) {