Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2518923003: Pass time constant to bwe smoothing filter. (Closed)
Patch Set: Add probing_interval_ms to NullBitrateObserver. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 kalman_estimator_(), 173 kalman_estimator_(),
174 trendline_estimator_(), 174 trendline_estimator_(),
175 detector_(OverUseDetectorOptions()), 175 detector_(OverUseDetectorOptions()),
176 receiver_incoming_bitrate_(), 176 receiver_incoming_bitrate_(),
177 last_update_ms_(-1), 177 last_update_ms_(-1),
178 last_seen_packet_ms_(-1), 178 last_seen_packet_ms_(-1),
179 uma_recorded_(false), 179 uma_recorded_(false),
180 trendline_window_size_(kDefaultTrendlineWindowSize), 180 trendline_window_size_(kDefaultTrendlineWindowSize),
181 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff), 181 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff),
182 trendline_threshold_gain_(kDefaultTrendlineThresholdGain), 182 trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
183 in_trendline_experiment_(TrendlineFilterExperimentIsEnabled()) { 183 in_trendline_experiment_(TrendlineFilterExperimentIsEnabled()),
184 probing_interval_estimator_(&rate_control_) {
184 if (in_trendline_experiment_) { 185 if (in_trendline_experiment_) {
185 ReadTrendlineFilterExperimentParameters(&trendline_window_size_, 186 ReadTrendlineFilterExperimentParameters(&trendline_window_size_,
186 &trendline_smoothing_coeff_, 187 &trendline_smoothing_coeff_,
187 &trendline_threshold_gain_); 188 &trendline_threshold_gain_);
188 } 189 }
189 network_thread_.DetachFromThread(); 190 network_thread_.DetachFromThread();
190 } 191 }
191 192
192 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector( 193 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
193 const std::vector<PacketInfo>& packet_feedback_vector) { 194 const std::vector<PacketInfo>& packet_feedback_vector) {
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 *ssrcs = {kFixedSsrc}; 324 *ssrcs = {kFixedSsrc};
324 *bitrate_bps = rate_control_.LatestEstimate(); 325 *bitrate_bps = rate_control_.LatestEstimate();
325 return true; 326 return true;
326 } 327 }
327 328
328 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) { 329 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
329 // Called from both the configuration thread and the network thread. Shouldn't 330 // Called from both the configuration thread and the network thread. Shouldn't
330 // be called from the network thread in the future. 331 // be called from the network thread in the future.
331 rate_control_.SetMinBitrate(min_bitrate_bps); 332 rate_control_.SetMinBitrate(min_bitrate_bps);
332 } 333 }
334
335 int64_t DelayBasedBwe::GetProbingIntervalMs() const {
336 return probing_interval_estimator_.GetIntervalMs();
337 }
333 } // namespace webrtc 338 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698