Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2518723002: Revert of Remove unused HttpClient class. (Closed)

Created:
4 years, 1 month ago by honghaiz3
Modified:
4 years, 1 month ago
Reviewers:
the sun, tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove unused HttpClient class. (patchset #1 id:1 of https://codereview.webrtc.org/2511883005/ ) Reason for revert: This class is used by downstream applications. Original issue's description: > Remove unused HttpClient class. > > BUG=none > > Committed: https://crrev.com/4a698f611a4bed4e074a26556ca9262b182955ee > Cr-Commit-Position: refs/heads/master@{#15156} TBR=tommi@webrtc.org,solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/ed9dccf9e9764a3a70fce24fe705af0aa76eaec6 Cr-Commit-Position: refs/heads/master@{#15157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1033 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/httpclient.h View 1 chunk +196 lines, -0 lines 0 comments Download
A webrtc/base/httpclient.cc View 1 chunk +835 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
honghaiz3
Created Revert of Remove unused HttpClient class.
4 years, 1 month ago (2016-11-18 23:26:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2518723002/1
4 years, 1 month ago (2016-11-18 23:26:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 23:27:05 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed9dccf9e9764a3a70fce24fe705af0aa76eaec6 Cr-Commit-Position: refs/heads/master@{#15157}
4 years, 1 month ago (2016-11-18 23:27:17 UTC) #7
the sun
lgtm
4 years, 1 month ago (2016-11-18 23:42:18 UTC) #8
the sun
4 years, 1 month ago (2016-11-18 23:42:31 UTC) #9
Message was sent while issue was closed.
On 2016/11/18 23:42:18, the sun wrote:
> lgtm

thanks for reverting

Powered by Google App Engine
This is Rietveld 408576698