Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2518293002: Reland of Allow custom metrics implementations on Android. (Closed)

Created:
4 years, 1 month ago by sakal
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Allow custom metrics implementations on Android. (patchset #1 id:1 of https://codereview.webrtc.org/2516403002/ ) Reason for revert: Fix downstream. Original issue's description: > Revert of Allow custom metrics implementations on Android. (patchset #11 id:260001 of https://codereview.webrtc.org/2403463002/ ) > > Reason for revert: > Break downstream tests. > > Original issue's description: > > Allow custom metrics implementations on Android. > > > > BUG=webrtc:6499 > > > > Committed: https://crrev.com/de609b26c5fc77fd3388eae5594ee8a634edf8da > > Cr-Commit-Position: refs/heads/master@{#15169} > > TBR=kjellander@webrtc.org,magjed@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6499 > > Committed: https://crrev.com/f570a2804ed8af6f6586f4aea51e089bd55d7e42 > Cr-Commit-Position: refs/heads/master@{#15171} TBR=kjellander@webrtc.org,magjed@webrtc.org,philipel@webrtc.org BUG=webrtc:6499 Committed: https://crrev.com/08be78051273dcce451f86fbf584049f452a990a Cr-Commit-Position: refs/heads/master@{#15214}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix chromium error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -71 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/BUILD.gn View 1 2 8 chunks +23 lines, -4 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera1Session.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java View 1 1 chunk +0 lines, -1 line 0 comments Download
A webrtc/api/android/java/src/org/webrtc/Histogram.java View 1 chunk +44 lines, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Metrics.java View 1 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/jni/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/api/android/jni/androidhistogram_jni.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M webrtc/api/android/jni/androidmetrics_jni.cc View 1 3 chunks +2 lines, -25 lines 0 comments Download
M webrtc/api/android/jni/classreferenceholder.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/examples/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 37 (30 generated)
sakal
Created Reland of Allow custom metrics implementations on Android.
4 years, 1 month ago (2016-11-22 08:10:08 UTC) #1
kjellander_webrtc
lgtm. I assume this CL is unmodified?
4 years, 1 month ago (2016-11-22 08:17:20 UTC) #2
sakal
On 2016/11/22 08:17:20, kjellander_webrtc wrote: > lgtm. I assume this CL is unmodified? Yes, this ...
4 years, 1 month ago (2016-11-22 08:19:02 UTC) #3
magjed_webrtc
lgtm
4 years ago (2016-11-23 13:48:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2518293002/260001
4 years ago (2016-11-23 15:11:05 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:260001)
4 years ago (2016-11-23 15:12:26 UTC) #35
commit-bot: I haz the power
4 years ago (2016-11-23 15:12:34 UTC) #37
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08be78051273dcce451f86fbf584049f452a990a
Cr-Commit-Position: refs/heads/master@{#15214}

Powered by Google App Engine
This is Rietveld 408576698