Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: webrtc/p2p/quic/quictransport.h

Issue 2517883002: Refactoring that removes P2PTransport and DtlsTransport classes. (Closed)
Patch Set: Leaving comments about what we'd need to do to support QUIC again. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/quic/quictransport.h
diff --git a/webrtc/p2p/quic/quictransport.h b/webrtc/p2p/quic/quictransport.h
index 14bd13f3b2befff5b941c1de25dc4df533cc775a..1d2093709fb57cbb613aff38c5b2161bf2d33211 100644
--- a/webrtc/p2p/quic/quictransport.h
+++ b/webrtc/p2p/quic/quictransport.h
@@ -23,7 +23,11 @@ namespace cricket {
class P2PTransportChannel;
class PortAllocator;
-// TODO(mikescarlett): Refactor to avoid code duplication with DtlsTransport.
+// TODO(deadbeef): To get QUIC working with TransportController again, would
+// need to merge this class with Transport (or make separate DTLS/QUIC
+// subclasses). The only difference between the two (as of typing this) is that
+// the QUIC channel *requires* a fingerprint, whereas the DTLS channel can
+// operate in a passthrough mode when SDES is used.
class QuicTransport : public Transport {
public:
QuicTransport(const std::string& name,

Powered by Google App Engine
This is Rietveld 408576698