Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: webrtc/pc/channelmanager_unittest.cc

Issue 2517883002: Refactoring that removes P2PTransport and DtlsTransport classes. (Closed)
Patch Set: Adding stub transport.h file for backwards compat. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/mediasession.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channelmanager_unittest.cc
diff --git a/webrtc/pc/channelmanager_unittest.cc b/webrtc/pc/channelmanager_unittest.cc
index 174d064b0543b0da6fd8cd10ddf4a02910d79723..4e14453c633292adb8ba291f186ac49f93c65deb 100644
--- a/webrtc/pc/channelmanager_unittest.cc
+++ b/webrtc/pc/channelmanager_unittest.cc
@@ -143,31 +143,6 @@ TEST_F(ChannelManagerTest, CreateDestroyChannelsOnThread) {
cm_->Terminate();
}
-// Test that we fail to create a voice/video channel if the session is unable
-// to create a cricket::TransportChannel
-TEST_F(ChannelManagerTest, NoTransportChannelTest) {
- EXPECT_TRUE(cm_->Init());
- transport_controller_->set_fail_channel_creation(true);
- // The test is useless unless the session does not fail creating
- // cricket::TransportChannel.
- ASSERT_TRUE(transport_controller_->CreateTransportChannel_n(
- "audio", cricket::ICE_CANDIDATE_COMPONENT_RTP) == nullptr);
-
- cricket::VoiceChannel* voice_channel = cm_->CreateVoiceChannel(
- &fake_mc_, transport_controller_, cricket::CN_AUDIO, nullptr, false,
- AudioOptions());
- EXPECT_TRUE(voice_channel == nullptr);
- cricket::VideoChannel* video_channel = cm_->CreateVideoChannel(
- &fake_mc_, transport_controller_, cricket::CN_VIDEO, nullptr, false,
- VideoOptions());
- EXPECT_TRUE(video_channel == nullptr);
- cricket::DataChannel* data_channel =
- cm_->CreateDataChannel(transport_controller_, cricket::CN_DATA, nullptr,
- false, cricket::DCT_RTP);
- EXPECT_TRUE(data_channel == nullptr);
- cm_->Terminate();
-}
-
TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
std::vector<VideoCodec> codecs;
const VideoCodec rtx_codec(96, "rtx");
« no previous file with comments | « webrtc/pc/channel_unittest.cc ('k') | webrtc/pc/mediasession.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698