Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2517523003: Added a perf test for the residual echo detector. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added a perf test for the residual echo detector. This perf tests the echo detector in 3 scenarios: standalone, as part of APM with only the echo detector enabled and as part of a normally configured APM. BUG=webrtc:6525 Committed: https://crrev.com/3cfb3efd69d2be75ec826905123b5bf6d3b640cc Cr-Commit-Position: refs/heads/master@{#15224}

Patch Set 1 : Initial version #

Patch Set 2 : Refactored SimulatorBuffers and PerformanceTimer into separate classes. #

Patch Set 3 : Replaced <algorithm> by <numeric>. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -133 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc View 1 4 chunks +11 lines, -133 lines 0 comments Download
A webrtc/modules/audio_processing/residual_echo_detector_complexity_unittest.cc View 1 1 chunk +168 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/performance_timer.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/performance_timer.cc View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/simulator_buffers.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/simulator_buffers.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ivoc
Hi Henrik, PTAL.
4 years, 1 month ago (2016-11-18 13:17:42 UTC) #4
hlundin-webrtc
On 2016/11/18 13:17:42, ivoc wrote: > Hi Henrik, PTAL. There is a fair amount of ...
4 years ago (2016-11-22 13:25:30 UTC) #5
ivoc
On 2016/11/22 13:25:30, hlundin-webrtc wrote: > On 2016/11/18 13:17:42, ivoc wrote: > > Hi Henrik, ...
4 years ago (2016-11-23 14:08:44 UTC) #6
hlundin-webrtc
lgtm
4 years ago (2016-11-24 09:16:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2517523003/40001
4 years ago (2016-11-24 09:26:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12762) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years ago (2016-11-24 09:27:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2517523003/60001
4 years ago (2016-11-24 12:02:13 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-11-24 12:17:32 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-24 12:17:46 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cfb3efd69d2be75ec826905123b5bf6d3b640cc
Cr-Commit-Position: refs/heads/master@{#15224}

Powered by Google App Engine
This is Rietveld 408576698