Move VideoFrame and related declarations to webrtc/api/video.

webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "avfoundationvideocapturer.h"
 
 #import <AVFoundation/AVFoundation.h>
 #import <Foundation/Foundation.h>
 #if TARGET_OS_IPHONE
 #import <UIKit/UIKit.h>
 #endif
 
 #import "RTCDispatcher+Private.h"
 #import "WebRTC/RTCLogging.h"
 #if TARGET_OS_IPHONE
 #import "WebRTC/UIDevice+RTCDevice.h"
 #endif
 
 #include "libyuv/rotate.h"
 
+#include "webrtc/api/video/rotation.h"
 #include "webrtc/base/bind.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/thread.h"
 #include "webrtc/common_video/include/corevideo_frame_buffer.h"

[the sun, 2016/11/24 10:36:59]

Should corevideo_frame_buffer move here? The "sdk/"s should serve as tests for
the C++ API - that it provides the necessary "pins" on the chip - so no poking
around with internals should be required/allowed.

[nisse-webrtc, 2016/11/25 08:58:03]

I agree that makes some sense. But it's for someone more familiar with the objc
sdk to decide. (And doesn't have to be in this cl).

-#include "webrtc/common_video/rotation.h"
 
 // TODO(denicija): add support for higher frame rates.
 // See http://crbug/webrtc/6355 for more info.
 static const int kFramesPerSecond = 30;
 
 static inline BOOL IsMediaSubTypeSupported(FourCharCode mediaSubType) {
   return (mediaSubType == kCVPixelFormatType_420YpCbCr8PlanarFullRange ||
           mediaSubType == kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange);
 }
 
@@ skipping 778 matching lines @@
         buffer->width(), buffer->height(),
         static_cast<libyuv::RotationMode>(rotation));
     buffer = rotated_buffer;
   }
 
   OnFrame(webrtc::VideoFrame(buffer, rotation, translated_camera_time_us),
           captured_width, captured_height);
 }
 
 }  // namespace webrtc