Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2517163002: RTCStats operator== bugfix (Closed)

Created:
4 years, 1 month ago by hbos
Modified:
4 years, 1 month ago
Reviewers:
hta-webrtc, guidou
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCStats operator== bugfix a == b would return true if a.member is defined even if b.member is undefined if their values were equal. We would say that b does not have a value in that case but its value_ member would still be initialized to something that is being compared to. Bugfix makes sure not to do value comparison in this case if b is undefined. BUG=chromium:627816 Committed: https://crrev.com/28747969cd2530114759e9d61ee711b887189d72 Cr-Commit-Position: refs/heads/master@{#15172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/api/stats/rtcstats.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (12 generated)
hbos
Please take a look, guidou
4 years, 1 month ago (2016-11-21 14:32:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2517163002/1
4 years, 1 month ago (2016-11-21 17:15:45 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-21 17:15:47 UTC) #11
guidou
lgtm
4 years, 1 month ago (2016-11-21 17:15:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2517163002/1
4 years, 1 month ago (2016-11-21 17:16:04 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 17:17:45 UTC) #16
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28747969cd2530114759e9d61ee711b887189d72 Cr-Commit-Position: refs/heads/master@{#15172}
4 years, 1 month ago (2016-11-21 17:18:01 UTC) #18
hta-webrtc
4 years, 1 month ago (2016-11-21 17:41:54 UTC) #20
Message was sent while issue was closed.
lgtm

good catch.

Powered by Google App Engine
This is Rietveld 408576698