Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2517123002: iOS: Add FlexFEC-03 field trial. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm b/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm
index ac3a4b3e48abeb53ed9a96de49c44ff3075a8e78..129efae4ca817443bd0e0448835f103ff8565833 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm
@@ -20,6 +20,8 @@ static NSString * const kRTCEnableImprovedBitrateEstimateString =
@"WebRTC-ImprovedBitrateEstimate/Enabled/";
static NSString * const kRTCEnableAudioSendSideBweString =
@"WebRTC-Audio-SendSideBwe/Enabled/";
+static NSString * const kRTCEnableFlexfec03String =
+ @"WebRTC-FlexFEC-03/Enabled/";
static std::unique_ptr<char[]> gFieldTrialInitString;
void RTCInitFieldTrials(RTCFieldTrialOptions options) {
@@ -27,8 +29,8 @@ void RTCInitFieldTrials(RTCFieldTrialOptions options) {
if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) {
[fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString];
}
- if (options & RTCFieldTrialOptionsAudioSendSideBwe) {
- [fieldTrialInitString appendString:kRTCEnableAudioSendSideBweString];
+ if (options & RTCFieldTrialOptionsFlexfec03) {
tkchin_webrtc 2016/11/21 18:16:59 Shouldn't this be in a new block? Why is the audio
brandtr 2016/11/21 19:43:06 Yes, of course it should be a new block! And the a
tkchin_webrtc 2016/11/21 19:46:02 No worries, I was just confused :)
+ [fieldTrialInitString appendString:kRTCEnableFlexfec03String];
}
size_t len = fieldTrialInitString.length + 1;
gFieldTrialInitString.reset(new char[len]);

Powered by Google App Engine
This is Rietveld 408576698