webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc - Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/audio_format_conversion.cc ('K') | « webrtc/modules/audio_coding/codecs/audio_format_conversion.cc ('k') | webrtc/tools/BUILD.gn » ('j') | webrtc/voice_engine/channel_proxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

diff --git a/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc b/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

index 05b65c3b860f28db093636eea120176bc01388a2..1b0c5b8af3f5f2d05997c953c85dfeb6fac1bf32 100644

--- a/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

+++ b/webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.cc

@@ -132,27 +132,29 @@ class BuiltinAudioDecoderFactory : public AudioDecoderFactory {

std::vector<AudioCodecSpec> GetSupportedDecoders() override {

static std::vector<AudioCodecSpec> specs = {

#ifdef WEBRTC_CODEC_OPUS

- { { "opus", 48000, 2, {

- {"minptime", "10" },

- {"useinbandfec", "1" }

- }

- }, false

- },

+ {{"opus",

+ 48000,

+ 2,

+ { {"minptime", "10"},

+ {"stereo", "0"},

+ { "useinbandfec",

+ "1" } }},

+ false},

#endif

#if (defined(WEBRTC_CODEC_ISAC) || defined(WEBRTC_CODEC_ISACFX))

- { { "isac", 16000, 1 }, true },

+ {{"isac", 16000, 1}, true},

#endif

#if (defined(WEBRTC_CODEC_ISAC))

- { { "isac", 32000, 1 }, true },

+ {{"isac", 32000, 1}, true},

#endif

#ifdef WEBRTC_CODEC_G722

- { { "G722", 8000, 1 }, true },

+ {{"G722", 8000, 1}, true},

#endif

#ifdef WEBRTC_CODEC_ILBC

- { { "iLBC", 8000, 1 }, true },

+ {{"iLBC", 8000, 1}, true},

#endif

- { { "PCMU", 8000, 1 }, true },

- { { "PCMA", 8000, 1 }, true }

+ {{"PCMU", 8000, 1}, true},

+ {{"PCMA", 8000, 1}, true}

};

return specs;