webrtc/modules/audio_coding/codecs/audio_format.h - Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/audio_format.h

Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst (Closed)

Patch Set: add TODO Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/audio_format.h

diff --git a/webrtc/modules/audio_coding/codecs/audio_format.h b/webrtc/modules/audio_coding/codecs/audio_format.h

index 1199cc27cd39e26eb58599556d674c1a394ff956..b3f803cd967f03958f86ad45e43a4f263774ab74 100644

--- a/webrtc/modules/audio_coding/codecs/audio_format.h

+++ b/webrtc/modules/audio_coding/codecs/audio_format.h

@@ -26,10 +26,15 @@ struct SdpAudioFormat {

SdpAudioFormat(const SdpAudioFormat&);

SdpAudioFormat(SdpAudioFormat&&);

SdpAudioFormat(const char* name, int clockrate_hz, int num_channels);

+ SdpAudioFormat(const std::string& name, int clockrate_hz, int num_channels);

SdpAudioFormat(const char* name,

int clockrate_hz,

int num_channels,

- Parameters&& param);

+ const Parameters& param);

+ SdpAudioFormat(const std::string& name,

+ int clockrate_hz,

+ int num_channels,

+ const Parameters& param);

~SdpAudioFormat();

SdpAudioFormat& operator=(const SdpAudioFormat&);