Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: webrtc/modules/audio_coding/codecs/mock/mock_audio_decoder_factory.h

Issue 2516993002: Pass SdpAudioFormat through Channel, without converting to CodecInst (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_
12 #define WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_ 12 #define WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/scoped_ref_ptr.h" 16 #include "webrtc/base/scoped_ref_ptr.h"
17 #include "webrtc/modules/audio_coding/codecs/audio_decoder_factory.h" 17 #include "webrtc/modules/audio_coding/codecs/audio_decoder_factory.h"
18 #include "webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h"
the sun 2016/12/15 15:34:13 Why?
18 #include "webrtc/test/gmock.h" 19 #include "webrtc/test/gmock.h"
19 20
20 namespace webrtc { 21 namespace webrtc {
21 22
22 class MockAudioDecoderFactory : public AudioDecoderFactory { 23 class MockAudioDecoderFactory : public AudioDecoderFactory {
23 public: 24 public:
24 MOCK_METHOD0(GetSupportedDecoders, std::vector<AudioCodecSpec>()); 25 MOCK_METHOD0(GetSupportedDecoders, std::vector<AudioCodecSpec>());
26 MOCK_METHOD1(IsSupportedDecoder, bool(const SdpAudioFormat&));
25 std::unique_ptr<AudioDecoder> MakeAudioDecoder( 27 std::unique_ptr<AudioDecoder> MakeAudioDecoder(
26 const SdpAudioFormat& format) { 28 const SdpAudioFormat& format) {
27 std::unique_ptr<AudioDecoder> return_value; 29 std::unique_ptr<AudioDecoder> return_value;
28 MakeAudioDecoderMock(format, &return_value); 30 MakeAudioDecoderMock(format, &return_value);
29 return return_value; 31 return return_value;
30 } 32 }
31 MOCK_METHOD2(MakeAudioDecoderMock, 33 MOCK_METHOD2(MakeAudioDecoderMock,
32 void(const SdpAudioFormat& format, 34 void(const SdpAudioFormat& format,
33 std::unique_ptr<AudioDecoder>* return_value)); 35 std::unique_ptr<AudioDecoder>* return_value));
34 36
35 // Creates a MockAudioDecoderFactory with no formats and that may not be 37 // Creates a MockAudioDecoderFactory with no formats and that may not be
36 // invoked to create a codec - useful for initializing a voice engine, for 38 // invoked to create a codec - useful for initializing a voice engine, for
37 // example. 39 // example.
38 static rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> 40 static rtc::scoped_refptr<webrtc::MockAudioDecoderFactory>
39 CreateUnusedFactory() { 41 CreateUnusedFactory() {
40 using testing::_; 42 using testing::_;
41 using testing::AnyNumber; 43 using testing::AnyNumber;
42 using testing::Return; 44 using testing::Return;
43 45
44 rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> factory = 46 rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> factory =
45 new rtc::RefCountedObject<webrtc::MockAudioDecoderFactory>; 47 new rtc::RefCountedObject<webrtc::MockAudioDecoderFactory>;
46 ON_CALL(*factory.get(), GetSupportedDecoders()) 48 ON_CALL(*factory.get(), GetSupportedDecoders())
47 .WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>())); 49 .WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>()));
48 EXPECT_CALL(*factory.get(), GetSupportedDecoders()).Times(AnyNumber()); 50 EXPECT_CALL(*factory.get(), GetSupportedDecoders()).Times(AnyNumber());
51 ON_CALL(*factory, IsSupportedDecoder(_)).WillByDefault(Return(false));
52 EXPECT_CALL(*factory, IsSupportedDecoder(_)).Times(AnyNumber());
49 EXPECT_CALL(*factory.get(), MakeAudioDecoderMock(_, _)).Times(0); 53 EXPECT_CALL(*factory.get(), MakeAudioDecoderMock(_, _)).Times(0);
50 return factory; 54 return factory;
51 } 55 }
52 56
53 // Creates a MockAudioDecoderFactory with no formats that may be invoked to 57 // Creates a MockAudioDecoderFactory with no formats that may be invoked to
54 // create a codec any number of times. It will, though, return nullptr on each 58 // create a codec any number of times. It will, though, return nullptr on each
55 // call, since it supports no codecs. 59 // call, since it supports no codecs.
56 static rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> 60 static rtc::scoped_refptr<webrtc::MockAudioDecoderFactory>
57 CreateEmptyFactory() { 61 CreateEmptyFactory() {
58 using testing::_; 62 using testing::_;
59 using testing::AnyNumber; 63 using testing::AnyNumber;
60 using testing::Return; 64 using testing::Return;
61 using testing::SetArgPointee; 65 using testing::SetArgPointee;
62 66
63 rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> factory = 67 rtc::scoped_refptr<webrtc::MockAudioDecoderFactory> factory =
64 new rtc::RefCountedObject<webrtc::MockAudioDecoderFactory>; 68 new rtc::RefCountedObject<webrtc::MockAudioDecoderFactory>;
65 ON_CALL(*factory.get(), GetSupportedDecoders()) 69 ON_CALL(*factory.get(), GetSupportedDecoders())
66 .WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>())); 70 .WillByDefault(Return(std::vector<webrtc::AudioCodecSpec>()));
67 EXPECT_CALL(*factory.get(), GetSupportedDecoders()).Times(AnyNumber()); 71 EXPECT_CALL(*factory.get(), GetSupportedDecoders()).Times(AnyNumber());
72 ON_CALL(*factory, IsSupportedDecoder(_)).WillByDefault(Return(false));
73 EXPECT_CALL(*factory, IsSupportedDecoder(_)).Times(AnyNumber());
68 ON_CALL(*factory.get(), MakeAudioDecoderMock(_, _)) 74 ON_CALL(*factory.get(), MakeAudioDecoderMock(_, _))
69 .WillByDefault(SetArgPointee<1>(nullptr)); 75 .WillByDefault(SetArgPointee<1>(nullptr));
70 EXPECT_CALL(*factory.get(), MakeAudioDecoderMock(_, _)).Times(AnyNumber()); 76 EXPECT_CALL(*factory.get(), MakeAudioDecoderMock(_, _)).Times(AnyNumber());
71 return factory; 77 return factory;
72 } 78 }
73 }; 79 };
74 80
75 } // namespace webrtc 81 } // namespace webrtc
76 82
77 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_ 83 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_DECODER_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698