Pass SdpAudioFormat through Channel, without converting to CodecInst

webrtc/voice_engine/include/voe_codec.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 14 matching lines @@
 //  ...
 //  base->Terminate();
 //  base->Release();
 //  codec->Release();
 //  VoiceEngine::Delete(voe);
 //
 #ifndef WEBRTC_VOICE_ENGINE_VOE_CODEC_H
 #define WEBRTC_VOICE_ENGINE_VOE_CODEC_H
 
 #include "webrtc/common_types.h"
+#include "webrtc/modules/audio_coding/codecs/audio_format.h"
 
 namespace webrtc {
 
 class VoiceEngine;
 
 class WEBRTC_DLLEXPORT VoECodec {
  public:
   // Factory for the VoECodec sub-API. Increases an internal
   // reference counter if successful. Returns NULL if the API is not
   // supported or if construction fails.
@@ skipping 27 matching lines @@
   // Gets the currently received |codec| for a specific |channel|.
   virtual int GetRecCodec(int channel, CodecInst& codec) = 0;
 
   // Sets the dynamic payload type number for a particular |codec| or
   // disables (ignores) a codec for receiving. For instance, when receiving
   // an invite from a SIP-based client, this function can be used to change
   // the dynamic payload type number to match that in the INVITE SDP-
   // message. The utilized parameters in the |codec| structure are:
   // plname, plfreq, pltype and channels.
   virtual int SetRecPayloadType(int channel, const CodecInst& codec) = 0;
+  virtual int SetRecPayloadType(int channel,

[the sun, 2016/11/21 08:37:05]

Why do we need to add this to the legacy API?

[ossu, 2016/11/30 12:43:43]

Should we go from AudioReceiveStream directly through channel_proxy_ onto the
Channel instead?

+                                int payload_type,
+                                const SdpAudioFormat& format) = 0;
 
   // Gets the actual payload type that is set for receiving a |codec| on a
   // |channel|. The value it retrieves will either be the default payload
   // type, or a value earlier set with SetRecPayloadType().
   virtual int GetRecPayloadType(int channel, CodecInst& codec) = 0;
 
   // Sets the payload |type| for the sending of SID-frames with background
   // noise estimation during silence periods detected by the VAD.
   virtual int SetSendCNPayloadType(
       int channel,
@@ skipping 46 matching lines @@
   virtual int GetOpusDtxStatus(int channel, bool* enabled) { return -1; }
 
  protected:
   VoECodec() {}
   virtual ~VoECodec() {}
 };
 
 }  // namespace webrtc
 
 #endif  //  WEBRTC_VOICE_ENGINE_VOE_CODEC_H