Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2516983004: Move ownership of PacketRouter from CongestionController to Call. (Closed)
Patch Set: Add back packet_router method and 4-argument constructor. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 if (kv.first.GetDirection() == PacketDirection::kIncomingPacket) { 931 if (kv.first.GetDirection() == PacketDirection::kIncomingPacket) {
932 for (const LoggedRtcpPacket& rtcp_packet : kv.second) 932 for (const LoggedRtcpPacket& rtcp_packet : kv.second)
933 incoming_rtcp.insert( 933 incoming_rtcp.insert(
934 std::make_pair(rtcp_packet.timestamp, &rtcp_packet)); 934 std::make_pair(rtcp_packet.timestamp, &rtcp_packet));
935 } 935 }
936 } 936 }
937 937
938 SimulatedClock clock(0); 938 SimulatedClock clock(0);
939 BitrateObserver observer; 939 BitrateObserver observer;
940 RtcEventLogNullImpl null_event_log; 940 RtcEventLogNullImpl null_event_log;
941 CongestionController cc(&clock, &observer, &observer, &null_event_log); 941 PacketRouter packet_router;
942 CongestionController cc(&clock, &observer, &observer, &null_event_log,
943 &packet_router);
942 // TODO(holmer): Log the call config and use that here instead. 944 // TODO(holmer): Log the call config and use that here instead.
943 static const uint32_t kDefaultStartBitrateBps = 300000; 945 static const uint32_t kDefaultStartBitrateBps = 300000;
944 cc.SetBweBitrates(0, kDefaultStartBitrateBps, -1); 946 cc.SetBweBitrates(0, kDefaultStartBitrateBps, -1);
945 947
946 TimeSeries time_series; 948 TimeSeries time_series;
947 time_series.label = "Delay-based estimate"; 949 time_series.label = "Delay-based estimate";
948 time_series.style = LINE_DOT_GRAPH; 950 time_series.style = LINE_DOT_GRAPH;
949 TimeSeries acked_time_series; 951 TimeSeries acked_time_series;
950 acked_time_series.label = "Acked bitrate"; 952 acked_time_series.label = "Acked bitrate";
951 acked_time_series.style = LINE_DOT_GRAPH; 953 acked_time_series.style = LINE_DOT_GRAPH;
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
1155 point.y -= estimated_base_delay_ms; 1157 point.y -= estimated_base_delay_ms;
1156 // Add the data set to the plot. 1158 // Add the data set to the plot.
1157 plot->series_list_.push_back(std::move(time_series)); 1159 plot->series_list_.push_back(std::move(time_series));
1158 1160
1159 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin); 1161 plot->SetXAxis(0, call_duration_s_, "Time (s)", kLeftMargin, kRightMargin);
1160 plot->SetSuggestedYAxis(0, 10, "Delay (ms)", kBottomMargin, kTopMargin); 1162 plot->SetSuggestedYAxis(0, 10, "Delay (ms)", kBottomMargin, kTopMargin);
1161 plot->SetTitle("Network Delay Change."); 1163 plot->SetTitle("Network Delay Change.");
1162 } 1164 }
1163 } // namespace plotting 1165 } // namespace plotting
1164 } // namespace webrtc 1166 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/fuzzers/congestion_controller_feedback_fuzzer.cc ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698