Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2516403002: Revert of Allow custom metrics implementations on Android. (Closed)

Created:
4 years, 1 month ago by philipel
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow custom metrics implementations on Android. (patchset #11 id:260001 of https://codereview.webrtc.org/2403463002/ ) Reason for revert: Break downstream tests. Original issue's description: > Allow custom metrics implementations on Android. > > BUG=webrtc:6499 > > Committed: https://crrev.com/de609b26c5fc77fd3388eae5594ee8a634edf8da > Cr-Commit-Position: refs/heads/master@{#15169} TBR=kjellander@webrtc.org,magjed@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6499 Committed: https://crrev.com/f570a2804ed8af6f6586f4aea51e089bd55d7e42 Cr-Commit-Position: refs/heads/master@{#15171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -119 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/BUILD.gn View 8 chunks +4 lines, -26 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera1Session.java View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/api/android/java/src/org/webrtc/Histogram.java View 1 chunk +0 lines, -44 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/Metrics.java View 1 chunk +35 lines, -0 lines 0 comments Download
M webrtc/api/android/java/src/org/webrtc/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/android/jni/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/android/jni/androidhistogram_jni.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M webrtc/api/android/jni/androidmetrics_jni.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M webrtc/api/android/jni/classreferenceholder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/examples/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
philipel
Created Revert of Allow custom metrics implementations on Android.
4 years, 1 month ago (2016-11-21 16:29:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2516403002/1
4 years, 1 month ago (2016-11-21 16:29:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:30:02 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f570a2804ed8af6f6586f4aea51e089bd55d7e42 Cr-Commit-Position: refs/heads/master@{#15171}
4 years, 1 month ago (2016-11-21 16:30:15 UTC) #7
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-11-21 20:41:45 UTC) #8
sakal
4 years, 1 month ago (2016-11-22 08:10:08 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2518293002/ by sakal@webrtc.org.

The reason for reverting is: Fix downstream..

Powered by Google App Engine
This is Rietveld 408576698