Move FirewallSocketServer to test code.

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 392 matching lines @@
     "crc32.cc",
     "crc32.h",
     "cryptstring.cc",
     "cryptstring.h",
     "diskcache.cc",
     "diskcache.h",
     "filerotatingstream.cc",
     "filerotatingstream.h",
     "fileutils.cc",
     "fileutils.h",
-    "firewallsocketserver.cc",
-    "firewallsocketserver.h",
     "flags.cc",
     "flags.h",
     "gunit_prod.h",
     "helpers.cc",
     "helpers.h",
     "httpbase.cc",
     "httpbase.h",
     "httpclient.cc",
     "httpclient.h",
     "httpcommon-inl.h",
@@ skipping 333 matching lines @@
   config("rtc_base_tests_utils_warnings_config") {
     if (is_win && is_clang) {
       cflags = [
         # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6270
         "-Wno-reorder",
         "-Wno-sign-compare",
       ]
     }
   }
 
   rtc_source_set("rtc_base_tests_utils") {

[kjellander_webrtc, 2016/11/18 13:52:40]

Isn't it a lot easier to move it into this target instead? 

[nisse-webrtc, 2016/11/18 14:15:42]

Indeed, that's a lot simpler. See new patch set.

     testonly = true
     sources = [
       # Also use this as a convenient dumping ground for misc files that are
       # included by multiple targets below.
       "fakeclock.cc",
       "fakeclock.h",
       "fakenetwork.h",
       "fakesslidentity.h",
       "faketaskrunner.h",
       "gunit.h",
@@ skipping 27 matching lines @@
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
 
     deps = [
       "//base:base_java",
     ]
   }
 }