Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2515163002: Don't declare function arguments of array type (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't declare function arguments of array type They just decay to pointers anyway, so it's more honest to declare them as pointers. BUG=webrtc:5805 Committed: https://crrev.com/57c1ad3b16b222d5e63bf94d96a32c652e2e59d8 Cr-Commit-Position: refs/heads/master@{#15165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -29 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 4 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 5 chunks +17 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
kwiberg-webrtc
4 years, 1 month ago (2016-11-20 22:19:17 UTC) #4
ossu
lgtm
4 years, 1 month ago (2016-11-21 12:58:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2515163002/1
4 years, 1 month ago (2016-11-21 12:58:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 12:59:54 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 13:00:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57c1ad3b16b222d5e63bf94d96a32c652e2e59d8
Cr-Commit-Position: refs/heads/master@{#15165}

Powered by Google App Engine
This is Rietveld 408576698