Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2514793002:
Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. (Closed)
|
Created:
4 years, 1 month ago by sakal Modified:
4 years, 1 month ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionCorrectly pass drawn frame size when layout aspect ratio is used in EglRenderer.
Previously, layout matrix was not correctly taken into account when calculating
the drawn size of the frame.
BUG=webrtc:6470
Committed: https://crrev.com/6280960998305aa723b41a3180cd534d738f45fc
Cr-Commit-Position: refs/heads/master@{#15163}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (10 generated)
Description was changed from ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG= ========== to ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG=webrtc:6470 ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.webrtc.org/2514793002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/EglRenderer.java (right): https://codereview.webrtc.org/2514793002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/EglRenderer.java:555: if (frameAspectRatio > layoutAspectRatio) { I find it easier with: drawnFrameWidth = Math.min(frame.rotatedWidth(), (int) (frame.rotatedHeight() * layoutAspectRatio); drawnFrameHeight = Math.min(frame.rotatedHeight(), (int) (frame.rotatedWidth() / layoutAspectRatio); but I guess you disagree since you have done it like this?
lgtm https://codereview.webrtc.org/2514793002/diff/1/webrtc/api/android/java/src/o... File webrtc/api/android/java/src/org/webrtc/EglRenderer.java (right): https://codereview.webrtc.org/2514793002/diff/1/webrtc/api/android/java/src/o... webrtc/api/android/java/src/org/webrtc/EglRenderer.java:555: if (frameAspectRatio > layoutAspectRatio) { On 2016/11/18 16:31:17, magjed_webrtc wrote: > I find it easier with: > drawnFrameWidth = Math.min(frame.rotatedWidth(), (int) (frame.rotatedHeight() * > layoutAspectRatio); > drawnFrameHeight = Math.min(frame.rotatedHeight(), (int) (frame.rotatedWidth() / > layoutAspectRatio); > but I guess you disagree since you have done it like this? Nevermind, this is fine.
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479722523530590, "parent_rev":
["14bf27422d9a78f375f070d2f02ba1d7c6e9ff50", null], "commit_rev":
["0be0a395b2593252b26d4eddf22a02e0115a6c6e", null]}
Message was sent while issue was closed.
Description was changed from ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG=webrtc:6470 ========== to ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG=webrtc:6470 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG=webrtc:6470 ========== to ========== Correctly pass drawn frame size when layout aspect ratio is used in EglRenderer. Previously, layout matrix was not correctly taken into account when calculating the drawn size of the frame. BUG=webrtc:6470 Committed: https://crrev.com/6280960998305aa723b41a3180cd534d738f45fc Cr-Commit-Position: refs/heads/master@{#15163} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6280960998305aa723b41a3180cd534d738f45fc Cr-Commit-Position: refs/heads/master@{#15163} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
