Change rtc::TimeNanos and rtc::TimeMicros return value from uint64_t to int64_t.

webrtc/base/timeutils.h

Index: webrtc/base/timeutils.h
diff --git a/webrtc/base/timeutils.h b/webrtc/base/timeutils.h
index cc6deb47a9a4a4e04141a7e98a6a5f9da3324b19..f41bbb5ad0436ffbcd99e4da1b22c76f5ae35e5e 100644
--- a/webrtc/base/timeutils.h
+++ b/webrtc/base/timeutils.h
@@ -34,7 +34,7 @@ static const int64_t kNumNanosecsPerMicrosec =
 class ClockInterface {
  public:
   virtual ~ClockInterface() {}
-  virtual uint64_t TimeNanos() const = 0;
+  virtual int64_t TimeNanos() const = 0;

[kwiberg-webrtc, 2016/11/21 12:12:34]

With this (and the other changes to this file), you're changing the public API,
right? If so, shouldn't you (1) introduce new stuff, (2) announce that people
have X weeks to stop using the old stuff, (3) wait X weeks, (4) remove the old
stuff?

[nisse-webrtc, 2016/11/21 12:39:12]

What's "public" in base/ is a fuzzy line. This ClockInterface is intended for
testing only. I've found two uses outside of webrtc (which I think I was
involved in adding), and I think they are under control; they're there mainly
because ScopedFakeClock isn't imported into the projects in question.

TimeMicros and TimeNanos are potentially more of a problem. We could introduce
new names for them, but that would also add some confusion. My opionion is that
in the long run, it's more hassle to update all applications to use a new name,
than to update them to accept a different return type; if for no other reason, a
lot fewer of the call sites will require any changes. (In practice, I think we
can almost promise that the returned values will be representable in both
int64_t and uint64_t).

 };
 
 // Sets the global source of time. This is useful mainly for unit tests.
@@ -55,7 +55,7 @@ ClockInterface* SetClockForTesting(ClockInterface* clock);
 
 // Returns the actual system time, even if a clock is set for testing.
 // Useful for timeouts while using a test clock, or for logging.
-uint64_t SystemTimeNanos();
+int64_t SystemTimeNanos();
 int64_t SystemTimeMillis();
 
 // Returns the current time in milliseconds in 32 bits.
@@ -69,10 +69,11 @@ inline int64_t Time() {
 }
 
 // Returns the current time in microseconds.
-uint64_t TimeMicros();
+int64_t TimeMicros();
 
 // Returns the current time in nanoseconds.
-uint64_t TimeNanos();
+int64_t TimeNanos();
+
 
 // Returns a future timestamp, 'elapsed' milliseconds from now.
 int64_t TimeAfter(int64_t elapsed);
@@ -88,7 +89,7 @@ inline int64_t TimeSince(int64_t earlier) {
 }
 
 // The number of milliseconds that will elapse between now and 'later'.
-inline int64_t TimeUntil(uint64_t later) {
+inline int64_t TimeUntil(int64_t later) {
   return later - TimeMillis();
 }