webrtc/base/opensslstreamadapter.cc - Issue 2514553003: Change rtc::TimeNanos and rtc::TimeMicros return value from uint64_t to int64_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/opensslstreamadapter.cc

Issue 2514553003: Change rtc::TimeNanos and rtc::TimeMicros return value from uint64_t to int64_t. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/opensslstreamadapter.cc

diff --git a/webrtc/base/opensslstreamadapter.cc b/webrtc/base/opensslstreamadapter.cc

index d2f3bc49781d7d9aa8646df6d0956465b6a92a85..798384b0c6f9d4730628c645c7920c93384ab8e7 100644

--- a/webrtc/base/opensslstreamadapter.cc

+++ b/webrtc/base/opensslstreamadapter.cc

@@ -64,8 +64,9 @@ static SrtpCipherMapEntry SrtpCipherMap[] = {

#ifdef OPENSSL_IS_BORINGSSL

static void TimeCallback(const SSL* ssl, struct timeval* out_clock) {

- uint64_t time = TimeNanos();

+ int64_t time = TimeNanos();

out_clock->tv_sec = time / kNumNanosecsPerSec;

+ // TODO(nisse): The below looks very wrong.

out_clock->tv_usec = time / kNumNanosecsPerMicrosec;

}

#else // #ifdef OPENSSL_IS_BORINGSSL