Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2514383002: Move androidvideotracksource from api under api/android/jni. (Closed)

Created:
4 years ago by sakal
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move androidvideotracksource from api under api/android/jni. This file fits there more naturally since it has dependencies to jni. BUG=None Committed: https://crrev.com/0ce6aafc3283bb00cb7b957f2deed9ad0f085e73 Cr-Commit-Position: refs/heads/master@{#15179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -272 lines) Patch
M webrtc/api/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/android/jni/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/api/android/jni/androidvideotracksource.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/api/android/jni/androidvideotracksource.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M webrtc/api/android/jni/androidvideotracksource_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/api/androidvideotracksource.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/api/androidvideotracksource.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
sakal
PTAL There are also some formatting changes in this cl because presubmit wanted me to ...
4 years ago (2016-11-21 15:02:42 UTC) #2
magjed_webrtc
lgtm
4 years ago (2016-11-21 17:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2514383002/1
4 years ago (2016-11-21 17:09:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10462)
4 years ago (2016-11-21 17:11:54 UTC) #7
sakal
Additional approvals required, PTAL.
4 years ago (2016-11-22 08:33:06 UTC) #12
perkj_webrtc
On 2016/11/22 08:33:06, sakal wrote: > Additional approvals required, PTAL. rs lgtm Please create a ...
4 years ago (2016-11-22 09:07:29 UTC) #15
sakal
On 2016/11/22 09:07:29, perkj_webrtc wrote: > On 2016/11/22 08:33:06, sakal wrote: > > Additional approvals ...
4 years ago (2016-11-22 09:10:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2514383002/1
4 years ago (2016-11-22 09:23:56 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 09:26:19 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-22 09:26:28 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ce6aafc3283bb00cb7b957f2deed9ad0f085e73
Cr-Commit-Position: refs/heads/master@{#15179}

Powered by Google App Engine
This is Rietveld 408576698