Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 2513633002: Revert of Stop using hardcoded payload types for video codecs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | webrtc/video/video_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index d93dd247d1da3c16e775bb66bed129ebc12a3d24..3ff3bd23f51fafae5d3fb4ca54e887bc30f0adbe 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -353,20 +353,23 @@
};
TEST_F(EndToEndTest, SendsAndReceivesVP8Rotation90) {
- CodecObserver test(5, kVideoRotation_90, "VP8", VP8Encoder::Create(),
+ CodecObserver test(5, kVideoRotation_90, "VP8",
+ VideoEncoder::Create(VideoEncoder::kVp8),
VP8Decoder::Create());
RunBaseTest(&test);
}
#if !defined(RTC_DISABLE_VP9)
TEST_F(EndToEndTest, SendsAndReceivesVP9) {
- CodecObserver test(500, kVideoRotation_0, "VP9", VP9Encoder::Create(),
+ CodecObserver test(500, kVideoRotation_0, "VP9",
+ VideoEncoder::Create(VideoEncoder::kVp9),
VP9Decoder::Create());
RunBaseTest(&test);
}
TEST_F(EndToEndTest, SendsAndReceivesVP9VideoRotation90) {
- CodecObserver test(5, kVideoRotation_90, "VP9", VP9Encoder::Create(),
+ CodecObserver test(5, kVideoRotation_90, "VP9",
+ VideoEncoder::Create(VideoEncoder::kVp9),
VP9Decoder::Create());
RunBaseTest(&test);
}
@@ -374,13 +377,15 @@
#if defined(WEBRTC_USE_H264)
TEST_F(EndToEndTest, SendsAndReceivesH264) {
- CodecObserver test(500, kVideoRotation_0, "H264", H264Encoder::Create(),
+ CodecObserver test(500, kVideoRotation_0, "H264",
+ VideoEncoder::Create(VideoEncoder::kH264),
H264Decoder::Create());
RunBaseTest(&test);
}
TEST_F(EndToEndTest, SendsAndReceivesH264VideoRotation90) {
- CodecObserver test(5, kVideoRotation_90, "H264", H264Encoder::Create(),
+ CodecObserver test(5, kVideoRotation_90, "H264",
+ VideoEncoder::Create(VideoEncoder::kH264),
H264Decoder::Create());
RunBaseTest(&test);
}
@@ -760,7 +765,7 @@
ulpfec_sequence_number_(0),
has_last_sequence_number_(false),
last_sequence_number_(0),
- encoder_(VP8Encoder::Create()),
+ encoder_(VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)),
decoder_(VP8Decoder::Create()) {}
private:
@@ -928,7 +933,7 @@
retransmission_ssrc_(enable_rtx ? kSendRtxSsrcs[0]
: kVideoSendSsrcs[0]),
retransmission_payload_type_(GetPayloadType(enable_rtx, enable_red)),
- encoder_(VP8Encoder::Create()),
+ encoder_(VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)),
marker_bits_observed_(0),
retransmitted_timestamp_(0) {}
@@ -1327,7 +1332,7 @@
std::unique_ptr<VideoEncoder> encoders[kNumStreams];
for (size_t i = 0; i < kNumStreams; ++i)
- encoders[i].reset(VP8Encoder::Create());
+ encoders[i].reset(VideoEncoder::Create(VideoEncoder::kVp8));
VideoSendStream* send_streams[kNumStreams];
VideoReceiveStream* receive_streams[kNumStreams];
@@ -2177,7 +2182,9 @@
use_red_(use_red),
screenshare_(screenshare),
// This test uses NACK, so to send FEC we can't use a fake encoder.
- vp8_encoder_(use_red ? VP8Encoder::Create() : nullptr),
+ vp8_encoder_(
+ use_red ? VideoEncoder::Create(VideoEncoder::EncoderType::kVp8)
+ : nullptr),
sender_call_(nullptr),
receiver_call_(nullptr),
start_runtime_ms_(-1),
@@ -3968,7 +3975,7 @@
VideoSendStream::Config* send_config,
std::vector<VideoReceiveStream::Config>* receive_configs,
VideoEncoderConfig* encoder_config) override {
- encoder_.reset(VP8Encoder::Create());
+ encoder_.reset(VideoEncoder::Create(VideoEncoder::kVp8));
decoder_.reset(VP8Decoder::Create());
send_config->post_encode_callback = this;
« no previous file with comments | « webrtc/video/BUILD.gn ('k') | webrtc/video/video_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698