Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: webrtc/media/engine/internalencoderfactory.cc

Issue 2513633002: Revert of Stop using hardcoded payload types for video codecs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.h ('k') | webrtc/media/engine/payload_type_mapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/internalencoderfactory.cc
diff --git a/webrtc/media/engine/internalencoderfactory.cc b/webrtc/media/engine/internalencoderfactory.cc
deleted file mode 100644
index f7c80a032447c5ab1b9614d1405647ccf166901e..0000000000000000000000000000000000000000
--- a/webrtc/media/engine/internalencoderfactory.cc
+++ /dev/null
@@ -1,74 +0,0 @@
-/*
- * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "webrtc/media/engine/internalencoderfactory.h"
-
-#include <utility>
-
-#include "webrtc/modules/video_coding/codecs/h264/include/h264.h"
-#include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
-#include "webrtc/modules/video_coding/codecs/vp9/include/vp9.h"
-
-namespace cricket {
-
-// static
-WebRtcVideoEncoderFactory& InternalEncoderFactory::GetInstance() {
- static InternalEncoderFactory instance;
- return instance;
-}
-
-InternalEncoderFactory::InternalEncoderFactory() {
- supported_codecs_.push_back(cricket::VideoCodec(kVp8CodecName));
- if (webrtc::VP9Encoder::IsSupported())
- supported_codecs_.push_back(cricket::VideoCodec(kVp9CodecName));
- if (webrtc::H264Encoder::IsSupported()) {
- cricket::VideoCodec codec(kH264CodecName);
- // TODO(magjed): Move setting these parameters into webrtc::H264Encoder
- // instead.
- // TODO(hta): Set FMTP parameters for all codecs of type H264.
- codec.SetParam(kH264FmtpProfileLevelId,
- kH264ProfileLevelConstrainedBaseline);
- codec.SetParam(kH264FmtpLevelAsymmetryAllowed, "1");
- codec.SetParam(kH264FmtpPacketizationMode, "1");
- supported_codecs_.push_back(std::move(codec));
- }
-
- supported_codecs_.push_back(cricket::VideoCodec(kRedCodecName));
- supported_codecs_.push_back(cricket::VideoCodec(kUlpfecCodecName));
-}
-
-InternalEncoderFactory::~InternalEncoderFactory() {}
-
-// WebRtcVideoEncoderFactory implementation.
-webrtc::VideoEncoder* InternalEncoderFactory::CreateVideoEncoder(
- const cricket::VideoCodec& codec) {
- switch (CodecTypeFromName(codec.name)) {
- case webrtc::kVideoCodecH264:
- return webrtc::H264Encoder::Create();
- case webrtc::kVideoCodecVP8:
- return webrtc::VP8Encoder::Create();
- case webrtc::kVideoCodecVP9:
- return webrtc::VP9Encoder::Create();
- default:
- return nullptr;
- }
-}
-
-const std::vector<cricket::VideoCodec>&
-InternalEncoderFactory::supported_codecs() const {
- return supported_codecs_;
-}
-
-void InternalEncoderFactory::DestroyVideoEncoder(
- webrtc::VideoEncoder* encoder) {
- delete encoder;
-}
-
-} // namespace cricket
« no previous file with comments | « webrtc/media/engine/internalencoderfactory.h ('k') | webrtc/media/engine/payload_type_mapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698