Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2513363004: WebRTC: Replace ProjectRootPath by ResourcePath (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRTC: Replace ProjectRootPath by ResourcePath BUG=webrtc:6727 NOTRY=True Committed: https://crrev.com/d661e9c3545d0dc56edff87e46adaa85e4067040 Cr-Commit-Position: refs/heads/master@{#15201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -166 lines) Patch
D data/voice_engine/audio_long16.pcm View Binary file 0 comments Download
D data/voice_engine/audio_tiny48.wav View Binary file 0 comments Download
M webrtc/modules/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/testsupport/fileutils.h View 2 chunks +2 lines, -71 lines 0 comments Download
M webrtc/test/testsupport/fileutils_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_streaming_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_streaming_fixture.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/resource_manager.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/resource_manager.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 3 chunks +3 lines, -7 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 chunk +2 lines, -14 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
ehmaldonado_webrtc
4 years, 1 month ago (2016-11-21 17:54:11 UTC) #8
kjellander_webrtc
nice cleanup. Was this the last traces of /data, e.g. could you delete the rest ...
4 years, 1 month ago (2016-11-21 20:39:32 UTC) #9
henrika_webrtc
Thanks. LGTM
4 years, 1 month ago (2016-11-22 08:17:07 UTC) #10
the sun
On 2016/11/22 08:17:07, henrika_webrtc wrote: > Thanks. LGTM Very nice, thanks!
4 years, 1 month ago (2016-11-22 09:27:28 UTC) #11
ehmaldonado_webrtc
On 2016/11/21 20:39:32, kjellander_webrtc wrote: > nice cleanup. > Was this the last traces of ...
4 years, 1 month ago (2016-11-22 13:31:38 UTC) #12
perkj_webrtc
lgtm
4 years, 1 month ago (2016-11-22 18:28:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2513363004/80001
4 years, 1 month ago (2016-11-22 18:41:23 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 1 month ago (2016-11-22 18:43:04 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 18:43:09 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d661e9c3545d0dc56edff87e46adaa85e4067040
Cr-Commit-Position: refs/heads/master@{#15201}

Powered by Google App Engine
This is Rietveld 408576698