Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2513213002: Enable ScreenCapturerIntegrationTests (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Jamie
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 Committed: https://crrev.com/166e59a70f86969479abf0067b3733a1686842c3 Cr-Commit-Position: refs/heads/master@{#15307}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove comments #

Patch Set 3 : Reduce test area on Windows to work around the unexpected warning window. #

Patch Set 4 : Update error message #

Patch Set 5 : Disable magnifier capturer tests on Windows 8 or later #

Patch Set 6 : Append bug id to magnifier capturer tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -26 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_integration_test.cc View 1 2 3 4 5 8 chunks +47 lines, -26 lines 0 comments Download

Messages

Total messages: 104 (89 generated)
Hzj_jie
I have run the tests for 38 times until now, and no failure caught. I ...
4 years, 1 month ago (2016-11-20 22:29:10 UTC) #14
Hzj_jie
p.s. You can get the history of test run at https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel?numbuilds=200 and https://build.chromium.org/p/tryserver.webrtc/builders/win_rel?numbuilds=200 and some ...
4 years, 1 month ago (2016-11-20 22:38:01 UTC) #15
kjellander_webrtc
lgtm with comment addressed https://codereview.webrtc.org/2513213002/diff/1/webrtc/modules/desktop_capture/screen_capturer_integration_test.cc File webrtc/modules/desktop_capture/screen_capturer_integration_test.cc (right): https://codereview.webrtc.org/2513213002/diff/1/webrtc/modules/desktop_capture/screen_capturer_integration_test.cc#newcode261 webrtc/modules/desktop_capture/screen_capturer_integration_test.cc:261: // https://bugs.chromium.org/p/webrtc/issues/detail?id=6666 Please also clean ...
4 years, 1 month ago (2016-11-21 06:49:10 UTC) #17
Hzj_jie
I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), both show a ...
4 years, 1 month ago (2016-11-21 20:58:25 UTC) #24
Hzj_jie
On 2016/11/21 20:58:25, Hzj_jie wrote: > I have succeeded got two errors on two machines ...
4 years ago (2016-11-28 20:21:42 UTC) #41
Hzj_jie
On 2016/11/28 20:21:42, Hzj_jie wrote: > On 2016/11/21 20:58:25, Hzj_jie wrote: > > I have ...
4 years ago (2016-11-28 20:49:32 UTC) #47
Hzj_jie
On 2016/11/28 20:49:32, Hzj_jie wrote: > On 2016/11/28 20:21:42, Hzj_jie wrote: > > On 2016/11/21 ...
4 years ago (2016-11-28 22:15:41 UTC) #48
Hzj_jie
On 2016/11/28 22:15:41, Hzj_jie wrote: > On 2016/11/28 20:49:32, Hzj_jie wrote: > > On 2016/11/28 ...
4 years ago (2016-11-29 03:45:42 UTC) #85
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2513213002/300001
4 years ago (2016-11-29 19:39:47 UTC) #90
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10803)
4 years ago (2016-11-29 19:45:41 UTC) #92
Hzj_jie
On 2016/11/29 19:45:41, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-11-29 19:51:16 UTC) #93
Sergey Ulanov
lgtm
4 years ago (2016-11-29 22:22:37 UTC) #94
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2513213002/320001
4 years ago (2016-11-29 22:30:29 UTC) #99
commit-bot: I haz the power
Committed patchset #6 (id:320001)
4 years ago (2016-11-29 22:46:51 UTC) #102
commit-bot: I haz the power
4 years ago (2016-11-29 22:47:01 UTC) #104
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/166e59a70f86969479abf0067b3733a1686842c3
Cr-Commit-Position: refs/heads/master@{#15307}

Powered by Google App Engine
This is Rietveld 408576698