|
|
DescriptionEnable ScreenCapturerIntegrationTests
This change enables ScreenCapturerIntegrationTests.
BUG=webrtc:6666
Committed: https://crrev.com/166e59a70f86969479abf0067b3733a1686842c3
Cr-Commit-Position: refs/heads/master@{#15307}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Remove comments #Patch Set 3 : Reduce test area on Windows to work around the unexpected warning window. #Patch Set 4 : Update error message #Patch Set 5 : Disable magnifier capturer tests on Windows 8 or later #Patch Set 6 : Append bug id to magnifier capturer tests #Messages
Total messages: 104 (89 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
zijiehe@chromium.org changed reviewers: + kjellander@chromium.org, sergeyu@chromium.org, skvlad@webrtc.org
I have run the tests for 38 times until now, and no failure caught. I would prefer to submit the change first, and see if we can get a valuable screenshot. To Sheriff Vladimir, these tests (ScreenCapturerIntegrationTest.*) were flaky during last several weeks, so they are disabled by change 2486553002. So I added more logging in change 2492723002, and plan to re-enable them. If a failure happened later, we can get a screenshot through stdio to help debugging.
p.s. You can get the history of test run at https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel?numbuilds=200 and https://build.chromium.org/p/tryserver.webrtc/builders/win_rel?numbuilds=200 and some other tryservers, by filtering 3898944d3215b77fab3bb0065da733ce61816d93.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
lgtm with comment addressed https://codereview.webrtc.org/2513213002/diff/1/webrtc/modules/desktop_captur... File webrtc/modules/desktop_capture/screen_capturer_integration_test.cc (right): https://codereview.webrtc.org/2513213002/diff/1/webrtc/modules/desktop_captur... webrtc/modules/desktop_capture/screen_capturer_integration_test.cc:261: // https://bugs.chromium.org/p/webrtc/issues/detail?id=6666 Please also clean up the comments about disabling before each test case.
Description was changed from ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 ========== to ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 ==========
kjellander@webrtc.org changed reviewers: - kjellander@chromium.org
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), both show a very interesting warning window. https://drive.google.com/file/d/0B0OFNI4uoZGRcFlMV2I2QmhzN0k/view?usp=sharing https://drive.google.com/file/d/0B0OFNI4uoZGRZzZVeHpCNjVnYXc/view?usp=sharing I would like to go further to understand which process shows this weird message box (hopefully it's not screen capturer itself), but I am blocked by 'prodaccess --chromegolo_ssh'. I got 'Principal not a memory of production group' error. But I cannot find chrome-ssh-proxy or chromegw in ganpati.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12818) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/12839) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/15190) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/15049) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20404) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19115)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12819) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/12840) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/15191) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/15050) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/20405) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/19116)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #3 (id:60001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2016/11/21 20:58:25, Hzj_jie wrote: > I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), both > show a very interesting warning window. > https://drive.google.com/file/d/0B0OFNI4uoZGRcFlMV2I2QmhzN0k/view?usp=sharing > https://drive.google.com/file/d/0B0OFNI4uoZGRZzZVeHpCNjVnYXc/view?usp=sharing > > I would like to go further to understand which process shows this weird message > box (hopefully it's not screen capturer itself), but I am blocked by 'prodaccess > --chromegolo_ssh'. I got 'Principal not a memory of production group' error. But > I cannot find chrome-ssh-proxy or chromegw in ganpati. This link (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.webrtc%2Fwin_x...) is a real failure. The capturer returns a blank frame (ff ff ff 00 in RGBA order). This seems like a known issue of GDI capturer on Windows, which happens randomly in our production. Rerunning the test case can usually resolve the issue.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Patchset #4 (id:100001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/28 20:21:42, Hzj_jie wrote: > On 2016/11/21 20:58:25, Hzj_jie wrote: > > I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), both > > show a very interesting warning window. > > https://drive.google.com/file/d/0B0OFNI4uoZGRcFlMV2I2QmhzN0k/view?usp=sharing > > https://drive.google.com/file/d/0B0OFNI4uoZGRZzZVeHpCNjVnYXc/view?usp=sharing > > > > I would like to go further to understand which process shows this weird > message > > box (hopefully it's not screen capturer itself), but I am blocked by > 'prodaccess > > --chromegolo_ssh'. I got 'Principal not a memory of production group' error. > But > > I cannot find chrome-ssh-proxy or chromegw in ganpati. > > This link > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.webrtc%2Fwin_x...) > is a real failure. The capturer returns a blank frame (ff ff ff 00 in RGBA > order). This seems like a known issue of GDI capturer on Windows, which happens > randomly in our production. Rerunning the test case can usually resolve the > issue. To be more accurate, the "known issue" here means we have got bug reports from chrome remote desktop users, instead of a known issue of Windows APIs.
On 2016/11/28 20:49:32, Hzj_jie wrote: > On 2016/11/28 20:21:42, Hzj_jie wrote: > > On 2016/11/21 20:58:25, Hzj_jie wrote: > > > I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), > both > > > show a very interesting warning window. > > > > https://drive.google.com/file/d/0B0OFNI4uoZGRcFlMV2I2QmhzN0k/view?usp=sharing > > > > https://drive.google.com/file/d/0B0OFNI4uoZGRZzZVeHpCNjVnYXc/view?usp=sharing > > > > > > I would like to go further to understand which process shows this weird > > message > > > box (hopefully it's not screen capturer itself), but I am blocked by > > 'prodaccess > > > --chromegolo_ssh'. I got 'Principal not a memory of production group' error. > > But > > > I cannot find chrome-ssh-proxy or chromegw in ganpati. > > > > This link > > > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.webrtc%2Fwin_x...) > > is a real failure. The capturer returns a blank frame (ff ff ff 00 in RGBA > > order). This seems like a known issue of GDI capturer on Windows, which > happens > > randomly in our production. Rerunning the test case can usually resolve the > > issue. > > To be more accurate, the "known issue" here means we have got bug reports from > chrome remote desktop users, instead of a known issue of Windows APIs. Two failures of ScreenCapturerWinMagnifier on Windows 8 and Windows 10 have been caught at, https://drive.google.com/file/d/0B0OFNI4uoZGRem0yT0pCakxoOU0/view?usp=sharing https://drive.google.com/file/d/0B0OFNI4uoZGRcDEwakdHVU5JbkU/view?usp=sharing The behavior of magnifier APIs have been changed on Windows 8 and Windows 10, so a border has been added to the image. I will contact the consumers of the capturer. But for now, the test case will be modified on Windows 8 or upper to work around.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #5 (id:140001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #5 (id:160001) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #5 (id:180001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #5 (id:200001) has been deleted
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #5 (id:220001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #7 (id:280001) has been deleted
Patchset #6 (id:260001) has been deleted
Patchset #5 (id:240001) has been deleted
On 2016/11/28 22:15:41, Hzj_jie wrote: > On 2016/11/28 20:49:32, Hzj_jie wrote: > > On 2016/11/28 20:21:42, Hzj_jie wrote: > > > On 2016/11/21 20:58:25, Hzj_jie wrote: > > > > I have succeeded got two errors on two machines (vm407-m4 and vm208-m4), > > both > > > > show a very interesting warning window. > > > > > > https://drive.google.com/file/d/0B0OFNI4uoZGRcFlMV2I2QmhzN0k/view?usp=sharing > > > > > > https://drive.google.com/file/d/0B0OFNI4uoZGRZzZVeHpCNjVnYXc/view?usp=sharing > > > > > > > > I would like to go further to understand which process shows this weird > > > message > > > > box (hopefully it's not screen capturer itself), but I am blocked by > > > 'prodaccess > > > > --chromegolo_ssh'. I got 'Principal not a memory of production group' > error. > > > But > > > > I cannot find chrome-ssh-proxy or chromegw in ganpati. > > > > > > This link > > > > > > (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.webrtc%2Fwin_x...) > > > is a real failure. The capturer returns a blank frame (ff ff ff 00 in RGBA > > > order). This seems like a known issue of GDI capturer on Windows, which > > happens > > > randomly in our production. Rerunning the test case can usually resolve the > > > issue. > > > > To be more accurate, the "known issue" here means we have got bug reports from > > chrome remote desktop users, instead of a known issue of Windows APIs. > > Two failures of ScreenCapturerWinMagnifier on Windows 8 and Windows 10 have been > caught at, > https://drive.google.com/file/d/0B0OFNI4uoZGRem0yT0pCakxoOU0/view?usp=sharing > https://drive.google.com/file/d/0B0OFNI4uoZGRcDEwakdHVU5JbkU/view?usp=sharing > The behavior of magnifier APIs have been changed on Windows 8 and Windows 10, so > a border has been added to the image. I will contact the consumers of the > capturer. But for now, the test case will be modified on Windows 8 or upper to > work around. After several attempts, I have to disable tests of magnifier capturer on Windows 8 or later. I am still investigating the root cause, but it cannot reproduce on my local dev machine, which is annoying.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2513213002/#ps300001 (title: "Disable magnifier capturer tests on Windows 8 or later")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10803)
On 2016/11/29 19:45:41, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10803) Sergey, I need your LGTM to submit this change.
lgtm
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by zijiehe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2513213002/#ps320001 (title: "Append bug id to magnifier capturer tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 320001, "attempt_start_ts": 1480458620365320, "parent_rev": "b8e1e7cd6dc3f2416c39d00127c5b6389b23084a", "commit_rev": "ab9d30b35420ff8ca911ed4c049f4e4db6231f83"}
Message was sent while issue was closed.
Description was changed from ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 ========== to ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:320001)
Message was sent while issue was closed.
Description was changed from ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 ========== to ========== Enable ScreenCapturerIntegrationTests This change enables ScreenCapturerIntegrationTests. BUG=webrtc:6666 Committed: https://crrev.com/166e59a70f86969479abf0067b3733a1686842c3 Cr-Commit-Position: refs/heads/master@{#15307} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/166e59a70f86969479abf0067b3733a1686842c3 Cr-Commit-Position: refs/heads/master@{#15307} |