Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2513103003: Remove deprecated CroppingWindowCapturer::Create (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated CroppingWindowCapturer::Create BUG=webrtc:6513 Committed: https://crrev.com/1b0e3aa440939ac6cfa8e5f66a615a51d0d6fda3 Cr-Commit-Position: refs/heads/master@{#15173}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Resolve review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Hzj_jie
4 years, 1 month ago (2016-11-18 23:20:25 UTC) #6
Sergey Ulanov
lgtm https://codereview.webrtc.org/2513103003/diff/1/webrtc/modules/desktop_capture/cropping_window_capturer.cc File webrtc/modules/desktop_capture/cropping_window_capturer.cc (right): https://codereview.webrtc.org/2513103003/diff/1/webrtc/modules/desktop_capture/cropping_window_capturer.cc#newcode107 webrtc/modules/desktop_capture/cropping_window_capturer.cc:107: return DesktopCapturer::CreateWindowCapturer(options); Add a comment here that CroppingWindowCapturer ...
4 years ago (2016-11-21 19:36:09 UTC) #7
Hzj_jie
https://codereview.webrtc.org/2513103003/diff/1/webrtc/modules/desktop_capture/cropping_window_capturer.cc File webrtc/modules/desktop_capture/cropping_window_capturer.cc (right): https://codereview.webrtc.org/2513103003/diff/1/webrtc/modules/desktop_capture/cropping_window_capturer.cc#newcode107 webrtc/modules/desktop_capture/cropping_window_capturer.cc:107: return DesktopCapturer::CreateWindowCapturer(options); On 2016/11/21 19:36:09, Sergey Ulanov wrote: > ...
4 years ago (2016-11-21 21:15:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2513103003/20001
4 years ago (2016-11-21 21:53:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-21 21:54:29 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-21 21:54:37 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b0e3aa440939ac6cfa8e5f66a615a51d0d6fda3
Cr-Commit-Position: refs/heads/master@{#15173}

Powered by Google App Engine
This is Rietveld 408576698