Update gtest-parallel and introduce gtest-parallel-wrapper.

Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True

Committed: https://crrev.com/ab102f163255f54cb72dcd427767fd9a6dfbafba
Cr-Commit-Position: refs/heads/master@{#15170}

[ehmaldonado_webrtc, 2016-11-18 21:43:27]

Patchset #1 (id:1) has been deleted

[ehmaldonado_webrtc, 2016-11-18 21:43:35]

Patchset #3 (id:60001) has been deleted

[ehmaldonado_webrtc, 2016-11-18 21:43:48]

Patchset #2 (id:40001) has been deleted

[ehmaldonado_webrtc, 2016-11-18 21:43:56]

Patchset #1 (id:20001) has been deleted

[ehmaldonado_webrtc, 2016-11-18 21:50:34]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org, pbos@webrtc.org

[ehmaldonado_webrtc, 2016-11-18 21:53:34]

Description was changed from

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

BUG=chromium:497757
==========

to

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

BUG=chromium:497757
==========

[kjellander_webrtc, 2016-11-21 07:14:31]

https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
third_party/gtest-parallel/gtest-parallel-wrapper.py:15: # GTEST_SHARD_INDEX and
GTEST_TOTAL_SHARDS must be removed from the environment
Ah, I didn't know having these set caused bugs. Then I'm much more supportive to
adding this wrapper!

https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
third_party/gtest-parallel/gtest-parallel-wrapper.py:37:
sys.exit(subprocess.call(command, env=test_env, cwd=os.getcwd()))
What if one runs this script and presses ctrl+c to abort execution. Does that
termination signal propagate properly? I remember gtest-parallel had issues with
this in the early days so I want to make sure adding this new layer on top of it
makes it as easy to abort as before. Even if it's unlikely to be run by
developers aborting a buildbot could be a similar scenario.

[ehmaldonado_webrtc, 2016-11-21 13:23:57]

PTAL

https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):

https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
third_party/gtest-parallel/gtest-parallel-wrapper.py:37:
sys.exit(subprocess.call(command, env=test_env, cwd=os.getcwd()))
On 2016/11/21 07:14:31, kjellander_webrtc wrote:
> What if one runs this script and presses ctrl+c to abort execution. Does that
> termination signal propagate properly? I remember gtest-parallel had issues
with
> this in the early days so I want to make sure adding this new layer on top of
it
> makes it as easy to abort as before. Even if it's unlikely to be run by
> developers aborting a buildbot could be a similar scenario.

It seems like I can abort it just fine. Maybe you can patch and confirm?

[kjellander_webrtc, 2016-11-21 14:21:28]

On 2016/11/21 13:23:57, ehmaldonado_webrtc wrote:
> PTAL
> 
>
https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
> File third_party/gtest-parallel/gtest-parallel-wrapper.py (right):
> 
>
https://codereview.webrtc.org/2513073002/diff/80001/third_party/gtest-paralle...
> third_party/gtest-parallel/gtest-parallel-wrapper.py:37:
> sys.exit(subprocess.call(command, env=test_env, cwd=os.getcwd()))
> On 2016/11/21 07:14:31, kjellander_webrtc wrote:
> > What if one runs this script and presses ctrl+c to abort execution. Does
that
> > termination signal propagate properly? I remember gtest-parallel had issues
> with
> > this in the early days so I want to make sure adding this new layer on top
of
> it
> > makes it as easy to abort as before. Even if it's unlikely to be run by
> > developers aborting a buildbot could be a similar scenario.
> 
> It seems like I can abort it just fine. Maybe you can patch and confirm?

No need. That should be sufficient.

[kjellander_webrtc, 2016-11-21 14:21:40]

lgtm

[kjellander_webrtc, 2016-11-21 14:23:09]

On 2016/11/21 14:21:40, kjellander_webrtc wrote:
> lgtm

Oh. Maybe add in local modifications of the README that you added the wrapper
script?

[ehmaldonado_webrtc, 2016-11-21 15:11:51]

Patchset #2 (id:100001) has been deleted

[ehmaldonado_webrtc, 2016-11-21 15:16:26]

Patchset #2 (id:120001) has been deleted

[ehmaldonado_webrtc, 2016-11-21 15:16:53]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-11-21 15:16:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2513073002/#ps140001 (title:
"Updated README.webrtc.")

[ehmaldonado_webrtc, 2016-11-21 15:16:56]

The CQ bit was unchecked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-11-21 15:16:56]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-11-21 15:16:56]

The CQ bit was unchecked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2016-11-21 15:17:08]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-11-21 15:17:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-21 15:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 15:19:41]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/10458)

[ehmaldonado_webrtc, 2016-11-21 15:33:38]

Description was changed from

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

BUG=chromium:497757
==========

to

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
==========

[ehmaldonado_webrtc, 2016-11-21 15:34:05]

Description was changed from

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
==========

to

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True
==========

[ehmaldonado_webrtc, 2016-11-21 15:59:31]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2016-11-21 15:59:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-21 16:01:11]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1479743971142900,
"parent_rev": "ce9c010909d951ca1ebdcc5622ef4fb9082a0ed7", "commit_rev":
"c39b86882a45f5e4ce3337468c5de237b6a3e99b"}

[commit-bot: I haz the power, 2016-11-21 16:01:15]

Description was changed from

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True
==========

to

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True
==========

[commit-bot: I haz the power, 2016-11-21 16:01:16]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-11-21 16:01:22]

Description was changed from

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True
==========

to

==========
Update gtest-parallel and introduce gtest-parallel-wrapper.

Now gtest-parallel is the same as in the github repo.
A wrapper script was created to handle the environment variables.

TBR=pbos@webrtc.org
BUG=chromium:497757
NOTRY=True

Committed: https://crrev.com/ab102f163255f54cb72dcd427767fd9a6dfbafba
Cr-Commit-Position: refs/heads/master@{#15170}
==========

[commit-bot: I haz the power, 2016-11-21 16:01:23]

Patchset 2 (id:??) landed as
https://crrev.com/ab102f163255f54cb72dcd427767fd9a6dfbafba
Cr-Commit-Position: refs/heads/master@{#15170}