Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2282)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2512693002: Implement Theil-Sen's method for fitting a line to noisy data (used in bandwidth estimation). (Closed)
Patch Set: Use PercentileFilter to find median slope Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
index 3f26e592ae4d84dae03348bdfc1cb9d4aa25ac33..d97aa9d7d16c81ba2307b3bbb27df3f483c86a7d 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
@@ -229,4 +229,37 @@ TEST_F(DelayBasedBweTrendlineExperimentTest, CapacityDropOneStreamWrap) {
CapacityDropTestHelper(1, true, 600, 0);
}
+class DelayBasedBweTheilSenExperimentTest : public DelayBasedBweTest {
+ public:
+ DelayBasedBweTheilSenExperimentTest()
+ : override_field_trials_("WebRTC-BweTheilSenFilter/Enabled-20,4/") {}
+
+ protected:
+ void SetUp() override {
+ bitrate_estimator_.reset(new DelayBasedBwe(&clock_));
brandtr 2016/11/28 16:27:19 I think you could move this to the constructor?
terelius 2016/12/02 16:45:52 Done.
+ }
+
+ test::ScopedFieldTrials override_field_trials_;
+};
+
+TEST_F(DelayBasedBweTheilSenExperimentTest, RateIncreaseRtpTimestamps) {
+ RateIncreaseRtpTimestampsTestHelper(1240);
+}
+
+TEST_F(DelayBasedBweTheilSenExperimentTest, CapacityDropOneStream) {
+ CapacityDropTestHelper(1, false, 600, 0);
+}
+
+TEST_F(DelayBasedBweTheilSenExperimentTest, CapacityDropPosOffsetChange) {
+ CapacityDropTestHelper(1, false, 600, 30000);
+}
+
+TEST_F(DelayBasedBweTheilSenExperimentTest, CapacityDropNegOffsetChange) {
+ CapacityDropTestHelper(1, false, 1267, -30000);
+}
+
+TEST_F(DelayBasedBweTheilSenExperimentTest, CapacityDropOneStreamWrap) {
+ CapacityDropTestHelper(1, true, 600, 0);
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698