Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: webrtc/base/analytics/percentile_filter_unittest.cc

Issue 2512693002: Implement Theil-Sen's method for fitting a line to noisy data (used in bandwidth estimation). (Closed)
Patch Set: Unit test for return value of PercentileFilter::Erase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/analytics/percentile_filter_unittest.cc
diff --git a/webrtc/base/analytics/percentile_filter_unittest.cc b/webrtc/base/analytics/percentile_filter_unittest.cc
index 98168fd27be25da60a7e169b9cd0646a3c41d89f..f63233aba495935494906ba908afecbac2b8947a 100644
--- a/webrtc/base/analytics/percentile_filter_unittest.cc
+++ b/webrtc/base/analytics/percentile_filter_unittest.cc
@@ -81,18 +81,42 @@ TEST(PercentileFilterTest, MedianFilterUnsigned) {
EXPECT_EQ(1u, filter.GetPercentileValue());
}
+TEST(PercentileFilterTest, ClearContents) {
+ PercentileFilter<int> filter(0.5f);
+ EXPECT_EQ(0, filter.GetPercentileValue());
+ filter.Insert(1);
+ filter.Insert(2);
+ filter.Insert(3);
+ EXPECT_EQ(2, filter.GetPercentileValue());
+ filter.Clear();
+ EXPECT_EQ(0, filter.GetPercentileValue());
+ filter.Insert(4);
+ filter.Insert(5);
+ filter.Insert(6);
+ EXPECT_EQ(5, filter.GetPercentileValue());
+ filter.Clear();
+ EXPECT_EQ(0, filter.GetPercentileValue());
+ filter.Insert(-1);
+ filter.Insert(-2);
+ filter.Insert(-3);
+ EXPECT_EQ(-2, filter.GetPercentileValue());
+}
+
TEST_P(PercentileFilterTest, EmptyFilter) {
EXPECT_EQ(0, filter_.GetPercentileValue());
filter_.Insert(3);
- filter_.Erase(3);
+ bool success = filter_.Erase(3);
+ EXPECT_EQ(true, success);
magjed_webrtc 2016/12/08 09:31:15 EXPECT_TRUE
terelius 2016/12/08 10:47:13 Done.
EXPECT_EQ(0, filter_.GetPercentileValue());
}
TEST_P(PercentileFilterTest, EraseNonExistingElement) {
- filter_.Erase(3);
+ bool success = filter_.Erase(3);
+ EXPECT_EQ(false, success);
magjed_webrtc 2016/12/08 09:31:15 EXPECT_FALSE
terelius 2016/12/08 10:47:13 Done.
EXPECT_EQ(0, filter_.GetPercentileValue());
filter_.Insert(4);
- filter_.Erase(3);
+ success = filter_.Erase(3);
+ EXPECT_EQ(false, success);
magjed_webrtc 2016/12/08 09:31:15 EXPECT_FALSE
terelius 2016/12/08 10:47:13 Done.
EXPECT_EQ(4, filter_.GetPercentileValue());
}

Powered by Google App Engine
This is Rietveld 408576698