Fix PayloadRouter::OnEncodedImage() to handle errors properly.

Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816
Committed: https://crrev.com/7b9feeeaad18a436d19f6c5172c5ad8468362814
Cr-Commit-Position: refs/heads/master@{#15143}

[Sergey Ulanov, 2016-11-16 23:29:08]

sergeyu@chromium.org changed reviewers:
+ stefan@webrtc.org

[Sergey Ulanov, 2016-11-16 23:33:00]

Description was changed from

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=665921
==========

to

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816
==========

[stefan-webrtc, 2016-11-17 11:25:15]

lgtm

[Sergey Ulanov, 2016-11-17 19:08:37]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 19:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:12:52]

Try jobs failed on following builders:
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/6943)

[Sergey Ulanov, 2016-11-17 23:00:09]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-11-17 23:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2512543002/#ps20001 (title:
"fix tests")

[commit-bot: I haz the power, 2016-11-17 23:00:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-17 23:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:04:27]

Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[Sergey Ulanov, 2016-11-17 23:46:16]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-11-17 23:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2512543002/#ps40001 (title:
"fix tests")

[commit-bot: I haz the power, 2016-11-17 23:46:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-18 00:16:17]

Description was changed from

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816
==========

to

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816
==========

[commit-bot: I haz the power, 2016-11-18 00:16:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-18 00:16:29]

Description was changed from

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816
==========

to

==========
Fix PayloadRouter::OnEncodedImage() to handle errors properly.

PayloadRouter::OnEncodedImage() was casing boolean result from
SendOutgoingData() to int, and then not handling it correctly, which
results in all errors in SendOutgoingData() being ignored. This issue
was introduced in
https://chromium.googlesource.com/external/webrtc/+/ad34dbe934

This bug masked another issue with VP9 codec (see
crbug.com/webrtc/6723 ) and that increased number of dropped frames.

BUG=634816

Committed: https://crrev.com/7b9feeeaad18a436d19f6c5172c5ad8468362814
Cr-Commit-Position: refs/heads/master@{#15143}
==========

[commit-bot: I haz the power, 2016-11-18 00:16:31]

Patchset 3 (id:??) landed as
https://crrev.com/7b9feeeaad18a436d19f6c5172c5ad8468362814
Cr-Commit-Position: refs/heads/master@{#15143}