Wire up FlexFEC in VideoEngine2.

webrtc/media/engine/fakewebrtccall.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 276 matching lines @@
 void FakeVideoReceiveStream::SetStats(
     const webrtc::VideoReceiveStream::Stats& stats) {
   stats_ = stats;
 }
 
 void FakeVideoReceiveStream::EnableEncodedFrameRecording(rtc::PlatformFile file,
                                                          size_t byte_limit) {
   rtc::ClosePlatformFile(file);
 }
 
+FakeFlexfecReceiveStream::FakeFlexfecReceiveStream(
+    webrtc::FlexfecReceiveStream::Config config)

[magjed_webrtc, 2016/11/17 13:37:19]

I think this should be:
FakeFlexfecReceiveStream(const webrtc::FlexfecReceiveStream::Config&)
If you want a move ctor, do it explicitly:
FakeFlexfecReceiveStream(webrtc::FlexfecReceiveStream::Config&&)
But this is a fake class, so I don't think we care that much about performance.
I would just go with a const-ref ctor.

[brandtr, 2016/11/17 17:28:57]

Yes, this was sloppy. Changed to const ref ctor!

+    : config_(std::move(config)), receiving_(false) {}
+
+const webrtc::FlexfecReceiveStream::Config&
+FakeFlexfecReceiveStream::GetConfig() {
+  return config_;
+}
+
+void FakeFlexfecReceiveStream::Start() {
+  receiving_ = true;
+}
+
+void FakeFlexfecReceiveStream::Stop() {
+  receiving_ = false;
+}
+
+// TODO(brandtr): Implement when the stats have been designed.
+webrtc::FlexfecReceiveStream::Stats FakeFlexfecReceiveStream::GetStats() const {
+  return webrtc::FlexfecReceiveStream::Stats();
+}
+
 FakeCall::FakeCall(const webrtc::Call::Config& config)
     : config_(config),
       audio_network_state_(webrtc::kNetworkUp),
       video_network_state_(webrtc::kNetworkUp),
       num_created_send_streams_(0),
       num_created_receive_streams_(0) {}
 
 FakeCall::~FakeCall() {
   EXPECT_EQ(0u, video_send_streams_.size());
   EXPECT_EQ(0u, audio_send_streams_.size());
@@ skipping 32 matching lines @@
 
 const FakeAudioReceiveStream* FakeCall::GetAudioReceiveStream(uint32_t ssrc) {
   for (const auto* p : GetAudioReceiveStreams()) {
     if (p->GetConfig().rtp.remote_ssrc == ssrc) {
       return p;
     }
   }
   return nullptr;
 }
 
+const std::vector<FakeFlexfecReceiveStream*>&
+FakeCall::GetFlexfecReceiveStreams() {
+  return flexfec_receive_streams_;
+}
+
 webrtc::NetworkState FakeCall::GetNetworkState(webrtc::MediaType media) const {
   switch (media) {
     case webrtc::MediaType::AUDIO:
       return audio_network_state_;
     case webrtc::MediaType::VIDEO:
       return video_network_state_;
     case webrtc::MediaType::DATA:
     case webrtc::MediaType::ANY:
       ADD_FAILURE() << "GetNetworkState called with unknown parameter.";
       return webrtc::kNetworkDown;
@@ skipping 83 matching lines @@
   if (it == video_receive_streams_.end()) {
     ADD_FAILURE() << "DestroyVideoReceiveStream called with unknown parameter.";
   } else {
     delete *it;
     video_receive_streams_.erase(it);
   }
 }
 
 webrtc::FlexfecReceiveStream* FakeCall::CreateFlexfecReceiveStream(
     webrtc::FlexfecReceiveStream::Config config) {
-  // TODO(brandtr): Implement when adding integration with WebRtcVideoEngine2.
-  return nullptr;
+  flexfec_receive_streams_.push_back(
+      new FakeFlexfecReceiveStream(std::move(config)));
+  ++num_created_receive_streams_;

[stefan-webrtc, 2016/11/17 12:48:59]

num_created_flexfec_receive_streams_....

[brandtr, 2016/11/17 13:23:36]

Don't think so, this variable is shared between video and audio:
https://cs.chromium.org/chromium/src/third_party/webrtc/media/engine/fakewebr...
https://cs.chromium.org/chromium/src/third_party/webrtc/media/engine/fakewebr...

+  return flexfec_receive_streams_.back();
 }
 
 void FakeCall::DestroyFlexfecReceiveStream(
     webrtc::FlexfecReceiveStream* receive_stream) {
-  // TODO(brandtr): Implement when adding integration with WebRtcVideoEngine2.
+  auto it = std::find(flexfec_receive_streams_.begin(),
+                      flexfec_receive_streams_.end(),
+                      static_cast<FakeFlexfecReceiveStream*>(receive_stream));
+  if (it == flexfec_receive_streams_.end()) {
+    ADD_FAILURE()
+        << "DestroyFlexfecReceiveStream called with unknown parameter.";
+  } else {
+    delete *it;
+    flexfec_receive_streams_.erase(it);
+  }
 }
 
 webrtc::PacketReceiver* FakeCall::Receiver() {
   return this;
 }
 
 FakeCall::DeliveryStatus FakeCall::DeliverPacket(
     webrtc::MediaType media_type,
     const uint8_t* packet,
     size_t length,
@@ skipping 76 matching lines @@
 }
 
 void FakeCall::OnSentPacket(const rtc::SentPacket& sent_packet) {
   last_sent_packet_ = sent_packet;
   if (sent_packet.packet_id >= 0) {
     last_sent_nonnegative_packet_id_ = sent_packet.packet_id;
   }
 }
 
 }  // namespace cricket