Wire up FlexFEC in VideoEngine2.

webrtc/config.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include "webrtc/config.h"
@@ skipping 32 matching lines @@
   ss << ", protected_media_ssrcs: [";
   size_t i = 0;
   for (; i + 1 < protected_media_ssrcs.size(); ++i)
     ss << protected_media_ssrcs[i] << ", ";
   if (!protected_media_ssrcs.empty())
     ss << protected_media_ssrcs[i];
   ss << "]}";
   return ss.str();
 }
 
+bool FlexfecConfig::IsValid() const {
+  if (flexfec_payload_type < 0)

[magjed_webrtc, 2016/11/17 13:37:19]

Isn't the valid payload type range 96-127 for this?

[brandtr, 2016/11/17 17:28:57]

Yes, you are right. My intention with this function is however to check if we
have enough information to enable FlexFEC/if we should enable FlexFEC. The way
to signal that we do not want to enable FlexFEC is to send a payload type of -1,
hence this check. To make my intentions clearer, I will rename this function and
remove the 127 check.

(The validity of the payload type values is checked in VideoSendStream. There we
however allow anything in the range 0-127. I'll check with danilchap if we
should tighten that.)

+    return false;
+  if (flexfec_payload_type > 127)
+    return false;
+  if (flexfec_ssrc == 0)
+    return false;
+  if (protected_media_ssrcs.size() != 1)
+    return false;
+  return true;
+}
+
 std::string RtpExtension::ToString() const {
   std::stringstream ss;
   ss << "{uri: " << uri;
   ss << ", id: " << id;
   ss << '}';
   return ss.str();
 }
 
 const char* RtpExtension::kAudioLevelUri =
     "urn:ietf:params:rtp-hdrext:ssrc-audio-level";
@@ skipping 154 matching lines @@
 void VideoEncoderConfig::Vp9EncoderSpecificSettings::FillVideoCodecVp9(
     VideoCodecVP9* vp9_settings) const {
   *vp9_settings = specifics_;
 }
 
 DecoderSpecificSettings::DecoderSpecificSettings() = default;
 
 DecoderSpecificSettings::~DecoderSpecificSettings() = default;
 
 }  // namespace webrtc