Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2511393002: Changed the way we find the ProjectRootPath. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed the way we find the ProjectRootPath. This was blocking swarming for memcheck. BUG=chromium:497757, webrtc:6727 Committed: https://crrev.com/00f2ee04d7d8488a4213cf20b98c3db72b2b1b60 Cr-Commit-Position: refs/heads/master@{#15153}

Patch Set 1 #

Patch Set 2 : Disable fileutils unittest in Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M webrtc/test/testsupport/fileutils.cc View 1 2 chunks +16 lines, -15 lines 0 comments Download
M webrtc/test/testsupport/fileutils_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
Tests seem to be happy :)
4 years, 1 month ago (2016-11-18 14:40:09 UTC) #2
kjellander_webrtc
On 2016/11/18 14:40:09, ehmaldonado_webrtc wrote: > Tests seem to be happy :) lgtm, mention in ...
4 years, 1 month ago (2016-11-18 14:45:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2511393002/20001
4 years, 1 month ago (2016-11-18 14:47:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 15:06:45 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 15:06:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00f2ee04d7d8488a4213cf20b98c3db72b2b1b60
Cr-Commit-Position: refs/heads/master@{#15153}

Powered by Google App Engine
This is Rietveld 408576698