Issue 2511103002: Delete WindowPicker class and subclasses.

Issue 2511103002: Delete WindowPicker class and subclasses. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc

Modified:
4 years, 1 month ago

Reviewers:
tommi, pthatcher1

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Delete WindowPicker class and subclasses. BUG=webrtc:6424 Committed: https://crrev.com/bbc747c116c731c6f6fbcc4dd1d98da520c03179 Cr-Commit-Position: refs/heads/master@{#15151}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1695 lines)			Patch
M	webrtc/BUILD.gn	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	webrtc/base/BUILD.gn	View		4 chunks	+0 lines, -15 lines	0 comments	Download
D	webrtc/base/macwindowpicker.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	webrtc/base/macwindowpicker.cc	View		1 chunk	+0 lines, -189 lines	0 comments	Download
D	webrtc/base/macwindowpicker_unittest.cc	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	webrtc/base/win32windowpicker.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
D	webrtc/base/win32windowpicker.cc	View		1 chunk	+0 lines, -144 lines	0 comments	Download
D	webrtc/base/win32windowpicker_unittest.cc	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	webrtc/base/windowpicker.h	View		1 chunk	+0 lines, -84 lines	0 comments	Download
D	webrtc/base/windowpicker_unittest.cc	View		1 chunk	+0 lines, -69 lines	0 comments	Download
D	webrtc/base/windowpickerfactory.h	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	webrtc/base/x11windowpicker.h	View		1 chunk	+0 lines, -53 lines	0 comments	Download
D	webrtc/base/x11windowpicker.cc	View		1 chunk	+0 lines, -816 lines	0 comments	Download
D	webrtc/base/x11windowpicker_unittest.cc	View		1 chunk	+0 lines, -40 lines	0 comments	Download

Total messages: 9 (4 generated)

nisse-webrtc

More dead code. Unclear when it was latest in use. (I will await result from ...

4 years, 1 month ago (2016-11-17 15:08:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2511103002/20001

4 years, 1 month ago (2016-11-18 10:26:19 UTC) #6

commit-bot: I haz the power

4 years, 1 month ago (2016-11-18 10:46:30 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/bbc747c116c731c6f6fbcc4dd1d98da520c03179
Cr-Commit-Position: refs/heads/master@{#15151}