webrtc/modules/video_coding/codecs/vp9/vp9_impl.h - Issue 2510583002: Reland #2 of Issue 2434073003: Extract bitrate allocation ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp9/vp9_impl.h

Issue 2510583002: Reland #2 of Issue 2434073003: Extract bitrate allocation ... (Closed)

Patch Set: Addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp9/vp9_impl.h

diff --git a/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h b/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h

index 7e65f3b21143bc1fd769f26cf5d7804e0ef50a01..4eb31a4256392da14d08492e089b5b673ef7cd13 100644

--- a/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h

+++ b/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h

@@ -46,7 +46,8 @@ class VP9EncoderImpl : public VP9Encoder {

int SetChannelParameters(uint32_t packet_loss, int64_t rtt) override;

- int SetRates(uint32_t new_bitrate_kbit, uint32_t frame_rate) override;

+ int SetRateAllocation(const BitrateAllocation& bitrate_allocation,

+ uint32_t frame_rate) override;

void OnDroppedFrame() override {}