Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc

Issue 2510583002: Reland #2 of Issue 2434073003: Extract bitrate allocation ... (Closed)
Patch Set: Addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc
index 1e36c448103329c08f4d0d4340911fa133deee39..e22c8b46757117fd8d805eafb0b164771dbd4d8a 100644
--- a/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/default_temporal_layers_unittest.cc
@@ -53,7 +53,8 @@ TEST(TemporalLayersTest, 2Layers) {
DefaultTemporalLayers tl(2, 0);
vpx_codec_enc_cfg_t cfg;
CodecSpecificInfoVP8 vp8_info;
- tl.ConfigureBitrates(500, 500, 30, &cfg);
+ tl.OnRatesUpdated(500, 500, 30);
+ tl.UpdateConfiguration(&cfg);
int expected_flags[16] = {
kTemporalUpdateLastAndGoldenRefAltRef,
@@ -94,7 +95,8 @@ TEST(TemporalLayersTest, 3Layers) {
DefaultTemporalLayers tl(3, 0);
vpx_codec_enc_cfg_t cfg;
CodecSpecificInfoVP8 vp8_info;
- tl.ConfigureBitrates(500, 500, 30, &cfg);
+ tl.OnRatesUpdated(500, 500, 30);
+ tl.UpdateConfiguration(&cfg);
int expected_flags[16] = {
kTemporalUpdateLastAndGoldenRefAltRef,
@@ -135,7 +137,8 @@ TEST(TemporalLayersTest, 4Layers) {
DefaultTemporalLayers tl(4, 0);
vpx_codec_enc_cfg_t cfg;
CodecSpecificInfoVP8 vp8_info;
- tl.ConfigureBitrates(500, 500, 30, &cfg);
+ tl.OnRatesUpdated(500, 500, 30);
+ tl.UpdateConfiguration(&cfg);
int expected_flags[16] = {
kTemporalUpdateLast,
kTemporalUpdateNone,
@@ -175,7 +178,8 @@ TEST(TemporalLayersTest, KeyFrame) {
DefaultTemporalLayers tl(3, 0);
vpx_codec_enc_cfg_t cfg;
CodecSpecificInfoVP8 vp8_info;
- tl.ConfigureBitrates(500, 500, 30, &cfg);
+ tl.OnRatesUpdated(500, 500, 30);
+ tl.UpdateConfiguration(&cfg);
int expected_flags[8] = {
kTemporalUpdateLastAndGoldenRefAltRef,

Powered by Google App Engine
This is Rietveld 408576698