Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java

Issue 2510413002: Set surface view surface size to minimum of the layout size and frame size. (Closed)
Patch Set: Changes according to magjed's comments. #2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java
diff --git a/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java b/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java
index 9fee0d00399d8ace934eb7f7cc08f07892783cd3..5e74e0e4bdbcc228815f2bb8f17e0fa124b52e4e 100644
--- a/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java
+++ b/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java
@@ -46,6 +46,11 @@ public class SurfaceViewRenderer
private int rotatedFrameHeight;
private int frameRotation;
+ // Accessed only on the main thread.
+ private boolean enableFixedSize;
+ private int surfaceWidth;
+ private int surfaceHeight;
+
/**
* Standard View constructor. In order to render something, you must first call init().
*/
@@ -104,6 +109,16 @@ public class SurfaceViewRenderer
}
/**
+ * Enables fixed size for the surface. This provides better performance but might be buggy on some
+ * devices. By default this is turned off.
+ */
+ public void setEnableHardwareScaler(boolean enabled) {
+ ThreadUtils.checkIsOnMainThread();
+ enableFixedSize = enabled;
+ updateSurfaceSize();
+ }
+
+ /**
* Set if the video stream should be mirrored or not.
*/
public void setMirror(final boolean mirror) {
@@ -148,6 +163,41 @@ public class SurfaceViewRenderer
protected void onLayout(boolean changed, int left, int top, int right, int bottom) {
ThreadUtils.checkIsOnMainThread();
eglRenderer.setLayoutAspectRatio((right - left) / (float) (bottom - top));
+ updateSurfaceSize();
+ }
+
+ private void updateSurfaceSize() {
+ ThreadUtils.checkIsOnMainThread();
+ synchronized (layoutLock) {
+ if (enableFixedSize && rotatedFrameWidth != 0 && rotatedFrameHeight != 0 && getWidth() != 0
+ && getHeight() != 0) {
+ final float layoutAspectRatio = getWidth() / (float) getHeight();
+ final float frameAspectRatio = rotatedFrameWidth / (float) rotatedFrameHeight;
+ final int drawnFrameWidth;
+ final int drawnFrameHeight;
+ if (frameAspectRatio > layoutAspectRatio) {
+ drawnFrameWidth = (int) (rotatedFrameHeight * layoutAspectRatio);
+ drawnFrameHeight = rotatedFrameHeight;
+ } else {
+ drawnFrameWidth = rotatedFrameWidth;
+ drawnFrameHeight = (int) (rotatedFrameWidth / layoutAspectRatio);
+ }
+ // Aspect ratio of the drawn frame and the view is the same.
+ final int width = Math.min(getWidth(), drawnFrameWidth);
+ final int height = Math.min(getHeight(), drawnFrameHeight);
+ logD("updateSurfaceSize. Layout size: " + getWidth() + "x" + getHeight() + ", frame size: "
+ + rotatedFrameWidth + "x" + rotatedFrameHeight + ", requested surface size: " + width
+ + "x" + height + ", old surface size: " + surfaceWidth + "x" + surfaceHeight);
+ if (width != surfaceWidth || height != surfaceHeight) {
+ surfaceWidth = width;
+ surfaceHeight = height;
+ getHolder().setFixedSize(width, height);
+ }
+ } else {
+ surfaceWidth = surfaceHeight = 0;
+ getHolder().setSizeFromLayout();
+ }
+ }
}
// SurfaceHolder.Callback interface.
@@ -155,6 +205,8 @@ public class SurfaceViewRenderer
public void surfaceCreated(final SurfaceHolder holder) {
ThreadUtils.checkIsOnMainThread();
eglRenderer.createEglSurface(holder.getSurface());
+ surfaceWidth = surfaceHeight = 0;
+ updateSurfaceSize();
}
@Override
@@ -173,6 +225,7 @@ public class SurfaceViewRenderer
@Override
public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) {
ThreadUtils.checkIsOnMainThread();
+ logD("surfaceChanged: format: " + format + " size: " + width + "x" + height);
eglRenderer.surfaceSizeChanged(width, height);
}
@@ -207,6 +260,7 @@ public class SurfaceViewRenderer
post(new Runnable() {
@Override
public void run() {
+ updateSurfaceSize();
requestLayout();
}
});
« no previous file with comments | « no previous file | webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698