Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2510373002: Revert of Move smoothing filter to common audio. (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move smoothing filter to common audio. (patchset #3 id:60001 of https://codereview.webrtc.org/2484153002/ ) Reason for revert: Breaks downstream projects: error: undefined reference to 'rtc::ExpFilter::kValueUndefined' error: undefined reference to 'rtc::ExpFilter::Apply(float, float)' error: undefined reference to 'rtc::ExpFilter::Reset(float)' rror: undefined reference to 'rtc::ExpFilter::UpdateBase(float)' Original issue's description: > Move smoothing filter to common audio. > > This will make the smoothing filter a basic tool that is going to be used by both voice engine and ANA. > > BUG=webrtc:6443 > > Committed: https://crrev.com/a82395bf7cd15b7396456df06fe952ede8db0c39 > Cr-Commit-Position: refs/heads/master@{#15146} TBR=minyue@webrtc.org,solenberg@webrtc.org,perkj@webrtc.org,tommi@webrtc.org,michaelt@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6443 Committed: https://crrev.com/d7ac0a9bcc5e9ff0eaf575ae3c886c0df92978f9 Cr-Commit-Position: refs/heads/master@{#15147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -267 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/common_audio/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
D webrtc/common_audio/mocks/mock_smoothing_filter.h View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/common_audio/smoothing_filter.h View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/common_audio/smoothing_filter.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/common_audio/smoothing_filter_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_unittest.cc View 4 chunks +4 lines, -1 line 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/mock/mock_smoothing_filter.h View 1 chunk +29 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.h View 1 chunk +54 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/audio_network_adaptor/smoothing_filter_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/aimd_rate_control_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
magjed_webrtc
Created Revert of Move smoothing filter to common audio.
4 years, 1 month ago (2016-11-18 09:31:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2510373002/1
4 years, 1 month ago (2016-11-18 09:31:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 09:31:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:31:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7ac0a9bcc5e9ff0eaf575ae3c886c0df92978f9
Cr-Commit-Position: refs/heads/master@{#15147}

Powered by Google App Engine
This is Rietveld 408576698