Add rtc_use_memcheck flag, update MB and GN to handle it, and add gni files listing the runtime deps

tools/mb/mb_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 """Tests for mb.py."""
 
+import ast
 import json
 import StringIO
 import os
 import sys
 import unittest
 
 import mb
 
 
 class FakeMBW(mb.MetaBuildWrapper):
@@ skipping 92 matching lines @@
 {
   'masters': {
     'chromium': {},
     'fake_master': {
       'fake_builder': 'gyp_rel_bot',
       'fake_gn_builder': 'gn_rel_bot',
       'fake_gyp_crosscompile_builder': 'gyp_crosscompile',
       'fake_gn_debug_builder': 'gn_debug_goma',
       'fake_gyp_builder': 'gyp_debug',
       'fake_gn_args_bot': '//build/args/bots/fake_master/fake_gn_args_bot.gn',
+      'fake_memcheck_bot': 'gn_memcheck_bot',
       'fake_multi_phase': { 'phase_1': 'gn_phase_1', 'phase_2': 'gn_phase_2'},
     },
   },
   'configs': {
     'gyp_rel_bot': ['gyp', 'rel', 'goma'],
     'gn_debug_goma': ['gn', 'debug', 'goma'],
     'gyp_debug': ['gyp', 'debug', 'fake_feature1'],
     'gn_rel_bot': ['gn', 'rel', 'goma'],
     'gyp_crosscompile': ['gyp', 'crosscompile'],
     'gn_phase_1': ['gn', 'phase_1'],
     'gn_phase_2': ['gn', 'phase_2'],
+    'gn_memcheck_bot': ['gn', 'memcheck'],
   },
   'mixins': {
     'crosscompile': {
       'gyp_crosscompile': True,
     },
     'fake_feature1': {
       'gn_args': 'enable_doom_melon=true',
       'gyp_defines': 'doom_melon=1',
     },
     'gyp': {'type': 'gyp'},
     'gn': {'type': 'gn'},
     'goma': {
       'gn_args': 'use_goma=true',
       'gyp_defines': 'goma=1',
     },
     'phase_1': {
       'gn_args': 'phase=1',
       'gyp_args': 'phase=1',
     },
     'phase_2': {
       'gn_args': 'phase=2',
       'gyp_args': 'phase=2',
     },
     'rel': {
       'gn_args': 'is_debug=false',
     },
     'debug': {
       'gn_args': 'is_debug=true',
     },
+    'memcheck': {
+      'gn_args': 'rtc_use_memcheck=true',
+    },
   },
 }
 """
 
 
 TEST_BAD_CONFIG = """\
 {
   'configs': {
     'gn_rel_bot_1': ['gn', 'rel', 'chrome_with_codecs'],
     'gn_rel_bot_2': ['gn', 'rel', 'bad_nested_config'],
@@ skipping 189 matching lines @@
                 '-c', 'gn_debug_goma',
                 '--swarming-targets-file', '/tmp/swarming_targets',
                 '--isolate-map-file',
                 '/fake_src/testing/buildbot/gn_isolate_map.pyl',
                 '//out/Default'], mbw=mbw, ret=0)
     self.assertIn('c:\\fake_src\\out\\Default\\cc_perftests.isolate',
                   mbw.files)
     self.assertIn('c:\\fake_src\\out\\Default\\cc_perftests.isolated.gen.json',
                   mbw.files)
 
+  def test_gn_gen_non_parallel_console_test_launcher(self):
+    test_files = {
+      '/tmp/swarming_targets': 'base_unittests\n',
+      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
+          "{'base_unittests': {"
+          "  'label': '//base:base_unittests',"
+          "  'type': 'non_parallel_console_test_launcher',"
+          "}}\n"
+      ),
+      '/fake_src/out/Default/base_unittests.runtime_deps': (
+          "base_unittests\n"
+      ),
+    }
+    mbw = self.check(['gen', '-c', 'gn_debug_goma', '//out/Default',
+                      '--swarming-targets-file', '/tmp/swarming_targets',
+                      '--isolate-map-file',
+                      '/fake_src/testing/buildbot/gn_isolate_map.pyl'],
+                     files=test_files, ret=0)
+
+    isolate_file = mbw.files['/fake_src/out/Default/base_unittests.isolate']
+    isolate_file_contents = ast.literal_eval(isolate_file)
+    files = isolate_file_contents['variables']['files']
+    command = isolate_file_contents['variables']['command']
+
+    self.assertEqual(files, [
+        '../../testing/test_env.py',
+        'base_unittests',
+    ])
+    self.assertEqual(command, [
+        '../../testing/test_env.py',
+        './base_unittests',
+        '--',
+        '--asan=0',
+        '--msan=0',
+        '--tsan=0',
+    ])
+
+  def test_gn_isolate_windowed_test_launcher_linux(self):
+    test_files = {
+      '/tmp/swarming_targets': 'base_unittests\n',
+      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
+          "{'base_unittests': {"
+          "  'label': '//base:base_unittests',"
+          "  'type': 'windowed_test_launcher',"
+          "}}\n"
+      ),
+      '/fake_src/out/Default/base_unittests.runtime_deps': (
+          "base_unittests\n"
+          "some_resource_file\n"
+      ),
+    }
+    mbw = self.check(['gen', '-c', 'gn_debug_goma', '//out/Default',
+                      '--swarming-targets-file', '/tmp/swarming_targets',
+                      '--isolate-map-file',
+                      '/fake_src/testing/buildbot/gn_isolate_map.pyl'],
+                     files=test_files, ret=0)
+
+    isolate_file = mbw.files['/fake_src/out/Default/base_unittests.isolate']
+    isolate_file_contents = ast.literal_eval(isolate_file)
+    files = isolate_file_contents['variables']['files']
+    command = isolate_file_contents['variables']['command']
+
+    self.assertEqual(files, [
+        '../../testing/test_env.py',
+        '../../testing/xvfb.py',
+        '../../third_party/gtest-parallel/gtest-parallel',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        'base_unittests',
+        'some_resource_file',
+        'xdisplaycheck',
+    ])
+    self.assertEqual(command, [
+        '../../testing/xvfb.py',
+        '.',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        './base_unittests',
+        '--',
+        '--asan=0',
+        '--msan=0',
+        '--tsan=0',
+    ])
+
+  def test_gn_gen_windowed_test_launcher_win(self):
+    files = {
+      '/tmp/swarming_targets': 'unittests\n',
+      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
+          "{'unittests': {"
+          "  'label': '//somewhere:unittests',"
+          "  'type': 'windowed_test_launcher',"
+          "}}\n"
+      ),
+      r'c:\fake_src\out\Default\unittests.exe.runtime_deps': (
+          "unittests.exe\n"
+          "some_dependency\n"
+      ),
+    }
+    mbw = self.fake_mbw(files=files, win32=True)
+    self.check(['gen',
+                '-c', 'gn_debug_goma',
+                '--swarming-targets-file', '/tmp/swarming_targets',
+                '--isolate-map-file',
+                '/fake_src/testing/buildbot/gn_isolate_map.pyl',
+                '//out/Default'], mbw=mbw, ret=0)
+
+    isolate_file = mbw.files['c:\\fake_src\\out\\Default\\unittests.isolate']
+    isolate_file_contents = ast.literal_eval(isolate_file)
+    files = isolate_file_contents['variables']['files']
+    command = isolate_file_contents['variables']['command']
+
+    self.assertEqual(files, [
+        '../../testing/test_env.py',
+        '../../third_party/gtest-parallel/gtest-parallel',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        'some_dependency',
+        'unittests.exe',
+    ])
+    self.assertEqual(command, [
+        '../../testing/test_env.py',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        r'.\unittests.exe',
+        '--',
+        '--asan=0',
+        '--msan=0',
+        '--tsan=0',
+    ])
+
+  def test_gn_gen_console_test_launcher(self):
+    test_files = {
+      '/tmp/swarming_targets': 'base_unittests\n',
+      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
+          "{'base_unittests': {"
+          "  'label': '//base:base_unittests',"
+          "  'type': 'console_test_launcher',"
+          "}}\n"
+      ),
+      '/fake_src/out/Default/base_unittests.runtime_deps': (
+          "base_unittests\n"
+      ),
+    }
+    mbw = self.check(['gen', '-c', 'gn_debug_goma', '//out/Default',
+                      '--swarming-targets-file', '/tmp/swarming_targets',
+                      '--isolate-map-file',
+                      '/fake_src/testing/buildbot/gn_isolate_map.pyl'],
+                     files=test_files, ret=0)
+
+    isolate_file = mbw.files['/fake_src/out/Default/base_unittests.isolate']
+    isolate_file_contents = ast.literal_eval(isolate_file)
+    files = isolate_file_contents['variables']['files']
+    command = isolate_file_contents['variables']['command']
+
+    self.assertEqual(files, [
+        '../../testing/test_env.py',
+        '../../third_party/gtest-parallel/gtest-parallel',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        'base_unittests',
+    ])
+    self.assertEqual(command, [
+        '../../testing/test_env.py',
+        '../../third_party/gtest-parallel/gtest-parallel-wrapper.py',
+        './base_unittests',
+        '--',
+        '--asan=0',
+        '--msan=0',
+        '--tsan=0',
+    ])
+
+  def test_gn_isolate_console_test_launcher_memcheck(self):
+    test_files = {
+      '/tmp/swarming_targets': 'base_unittests\n',
+      '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
+          "{'base_unittests': {"
+          "  'label': '//base:base_unittests',"
+          "  'type': 'console_test_launcher',"
+          "}}\n"
+      ),
+      '/fake_src/out/Release/base_unittests.runtime_deps': (
+          "base_unittests\n"
+          "lots_of_memcheck_dependencies\n"
+          "../../tools/valgrind-webrtc/webrtc_tests.sh\n"
+      ),
+    }
+    mbw = self.check(['gen', '-c', 'gn_memcheck_bot', '//out/Release',
+                      '--swarming-targets-file', '/tmp/swarming_targets',
+                      '--isolate-map-file',
+                      '/fake_src/testing/buildbot/gn_isolate_map.pyl'],
+                     files=test_files, ret=0)
+
+    isolate_file = mbw.files['/fake_src/out/Release/base_unittests.isolate']
+    isolate_file_contents = ast.literal_eval(isolate_file)
+    files = isolate_file_contents['variables']['files']
+    command = isolate_file_contents['variables']['command']
+
+    self.assertEqual(files, [
+        '../../testing/test_env.py',
+        '../../tools/valgrind-webrtc/webrtc_tests.sh',
+        'base_unittests',
+        'lots_of_memcheck_dependencies',
+    ])
+    self.assertEqual(command, [
+        '../../testing/test_env.py',
+        'bash',
+        '../../tools/valgrind-webrtc/webrtc_tests.sh',
+        '--tool',
+        'memcheck',
+        '--target',
+        'Release',
+        '--build-dir',
+        '..',
+        '--test',
+        './base_unittests',
+        '--',
+        '--asan=0',
+        '--msan=0',
+        '--tsan=0',
+    ])
 
   def test_gn_isolate(self):
     files = {
       '/fake_src/out/Default/toolchain.ninja': "",
       '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
           "{'base_unittests': {"
           "  'label': '//base:base_unittests',"
           "  'type': 'non_parallel_console_test_launcher',"
-          "  'args': [],"
           "}}\n"
       ),
       '/fake_src/out/Default/base_unittests.runtime_deps': (
           "base_unittests\n"
       ),
     }
     self.check(['isolate', '-c', 'gn_debug_goma', '//out/Default',
                 'base_unittests'], files=files, ret=0)
 
     # test running isolate on an existing build_dir
     files['/fake_src/out/Default/args.gn'] = 'is_debug = True\n'
     self.check(['isolate', '//out/Default', 'base_unittests'],
                files=files, ret=0)
-
     files['/fake_src/out/Default/mb_type'] = 'gn\n'
     self.check(['isolate', '//out/Default', 'base_unittests'],
                files=files, ret=0)
 
   def test_gn_run(self):
     files = {
       '/fake_src/testing/buildbot/gn_isolate_map.pyl': (
           "{'base_unittests': {"
           "  'label': '//base:base_unittests',"
           "  'type': 'windowed_test_launcher',"
-          "  'args': [],"
           "}}\n"
       ),
       '/fake_src/out/Default/base_unittests.runtime_deps': (
           "base_unittests\n"
       ),
     }
     self.check(['run', '-c', 'gn_debug_goma', '//out/Default',
                 'base_unittests'], files=files, ret=0)
 
   def test_gn_lookup(self):
@@ skipping 115 matching lines @@
     self.check(['lookup', '-c', 'fake_config'], mbw=mbw,
                ret=0,
                out=("GYP_DEFINES='foo=bar baz=1'\n"
                     "GYP_LINK_CONCURRENCY=1\n"
                     "LLVM_FORCE_HEAD_REVISION=1\n"
                     "python build/gyp_chromium -G output_dir=_path_\n"))
 
 
 if __name__ == '__main__':
   unittest.main()