Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.cc

Issue 2509273002: Unify VideoCodecType to/from string functionality (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2.cc b/webrtc/media/engine/webrtcvideoengine2.cc
index c43dff80d3d140f87334f482df5ae266026c4832..2262ddfeff67816f9b17dca97599823958532b1a 100644
--- a/webrtc/media/engine/webrtcvideoengine2.cc
+++ b/webrtc/media/engine/webrtcvideoengine2.cc
@@ -1727,7 +1727,8 @@ WebRtcVideoChannel2::WebRtcVideoSendStream::AllocatedEncoder
WebRtcVideoChannel2::WebRtcVideoSendStream::CreateVideoEncoder(
const VideoCodec& codec) {
RTC_DCHECK_RUN_ON(&thread_checker_);
- webrtc::VideoCodecType type = CodecTypeFromName(codec.name);
+ webrtc::VideoCodecType type = webrtc::PayloadNameToCodecType(codec.name)
+ .value_or(webrtc::kVideoCodecUnknown);
// Do not re-create encoders of the same type.
if (type == allocated_encoder_.type && allocated_encoder_.encoder != NULL) {
@@ -1780,7 +1781,9 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::SetCodec(
parameters_.config.encoder_settings.payload_name = codec_settings.codec.name;
parameters_.config.encoder_settings.payload_type = codec_settings.codec.id;
if (new_encoder.external) {
- webrtc::VideoCodecType type = CodecTypeFromName(codec_settings.codec.name);
+ webrtc::VideoCodecType type =
+ webrtc::PayloadNameToCodecType(codec_settings.codec.name)
+ .value_or(webrtc::kVideoCodecUnknown);
parameters_.config.encoder_settings.internal_source =
external_encoder_factory_->EncoderTypeHasInternalSource(type);
}
@@ -2219,7 +2222,8 @@ WebRtcVideoChannel2::WebRtcVideoReceiveStream::AllocatedDecoder
WebRtcVideoChannel2::WebRtcVideoReceiveStream::CreateOrReuseVideoDecoder(
std::vector<AllocatedDecoder>* old_decoders,
const VideoCodec& codec) {
- webrtc::VideoCodecType type = CodecTypeFromName(codec.name);
+ webrtc::VideoCodecType type = webrtc::PayloadNameToCodecType(codec.name)
+ .value_or(webrtc::kVideoCodecUnknown);
for (size_t i = 0; i < old_decoders->size(); ++i) {
if ((*old_decoders)[i].type == type) {

Powered by Google App Engine
This is Rietveld 408576698