Reland of Split out target rtc_media_base from rtc_media

Reland of Split out target rtc_media_base from rtc_media (patchset #1 id:1 of https://codereview.webrtc.org/2508163002/ )

Reason for revert:
Include fix for downstream import.

Original issue's description:
> Revert of Split out target rtc_media_base from rtc_media (patchset #3 id:40001 of https://codereview.webrtc.org/2471573003/ )
>
> Reason for revert:
> Breaks downstream import.
>
> Original issue's description:
> > Split out target rtc_media_base from rtc_media
> >
> > The purpose with this CL is to be able to depend on
> > cricket::VideoCodec (webrtc/media/base/codec.h) from other targets
> > without getting cyclic dependencies.
> >
> > BUG=webrtc:6402, webrtc:6337
> >
> > NOTRY=True
> >
> > Committed: https://crrev.com/aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a
> > Cr-Commit-Position: refs/heads/master@{#15137}
>
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6402, webrtc:6337
>
> Committed: https://crrev.com/0d0d7531b50a78efe7468610395e9dc5f496e2e9
> Cr-Commit-Position: refs/heads/master@{#15139}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6402, webrtc:6337
Committed: https://crrev.com/0928a3cf0f0552bb0dc29f58bf8e86bd089cd215
Cr-Commit-Position: refs/heads/master@{#15235}

[magjed_webrtc, 2016-11-17 16:17:56]

Created Reland of Split out target rtc_media_base from rtc_media

[kjellander_webrtc, 2016-11-17 16:36:13]

I'd like to see green Chromium trybots before approving this. 
I suspect you might need to create some kind of multi-step update.

https://codereview.webrtc.org/2509123003/diff/1/webrtc/media/BUILD.gn
File webrtc/media/BUILD.gn (right):

https://codereview.webrtc.org/2509123003/diff/1/webrtc/media/BUILD.gn#newcode15
webrtc/media/BUILD.gn:15: ":rtc_media_base",
Since it was already built via indirect dependency, I don't think this helps for
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...

Make sure you run Chromium trybots on this change.

[magjed_webrtc, 2016-11-17 16:52:24]

On 2016/11/17 16:36:13, kjellander_webrtc wrote:
> I'd like to see green Chromium trybots before approving this. 
> I suspect you might need to create some kind of multi-step update.
> 
> https://codereview.webrtc.org/2509123003/diff/1/webrtc/media/BUILD.gn
> File webrtc/media/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2509123003/diff/1/webrtc/media/BUILD.gn#newcode15
> webrtc/media/BUILD.gn:15: ":rtc_media_base",
> Since it was already built via indirect dependency, I don't think this helps
for
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> Make sure you run Chromium trybots on this change.

Yeah, I need to investigate this. I just created the reland CL so it shows up in
my review page so I don't forget it.

[magjed_webrtc, 2016-11-24 16:10:28]

kjellander - please take a look. Is this solution ok until I can update
Chromium? (The internal bot failure is unrelated to these changes)

[kjellander_webrtc, 2016-11-24 19:22:06]

lgtm, gn check can be annoying sometimes :)

I think the compile failure is not your fault. I saw a similar error for another
CL just now. You can probably just submit this since the other linux compile
passed.

[magjed_webrtc, 2016-11-25 08:40:05]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-11-25 08:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-25 08:40:19]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1480063205582530,
"parent_rev": "08fe42ea12243388207c2654ac9ca4c03b07a801", "commit_rev":
"125c8ad46f1b4dc12020b8285066106d4f18de92"}

[commit-bot: I haz the power, 2016-11-25 08:40:22]

Committed patchset #3 (id:90001)

[commit-bot: I haz the power, 2016-11-25 08:40:32]

Description was changed from

==========
Reland of Split out target rtc_media_base from rtc_media (patchset #1 id:1 of
https://codereview.webrtc.org/2508163002/ )

Reason for revert:
Include fix for downstream import.

Original issue's description:
> Revert of Split out target rtc_media_base from rtc_media (patchset #3 id:40001
of https://codereview.webrtc.org/2471573003/ )
> 
> Reason for revert:
> Breaks downstream import.
> 
> Original issue's description:
> > Split out target rtc_media_base from rtc_media
> >
> > The purpose with this CL is to be able to depend on
> > cricket::VideoCodec (webrtc/media/base/codec.h) from other targets
> > without getting cyclic dependencies.
> >
> > BUG=webrtc:6402,webrtc:6337
> >
> > NOTRY=True
> >
> > Committed: https://crrev.com/aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a
> > Cr-Commit-Position: refs/heads/master@{#15137}
> 
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6402,webrtc:6337
> 
> Committed: https://crrev.com/0d0d7531b50a78efe7468610395e9dc5f496e2e9
> Cr-Commit-Position: refs/heads/master@{#15139}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6402,webrtc:6337
==========

to

==========
Reland of Split out target rtc_media_base from rtc_media (patchset #1 id:1 of
https://codereview.webrtc.org/2508163002/ )

Reason for revert:
Include fix for downstream import.

Original issue's description:
> Revert of Split out target rtc_media_base from rtc_media (patchset #3 id:40001
of https://codereview.webrtc.org/2471573003/ )
>
> Reason for revert:
> Breaks downstream import.
>
> Original issue's description:
> > Split out target rtc_media_base from rtc_media
> >
> > The purpose with this CL is to be able to depend on
> > cricket::VideoCodec (webrtc/media/base/codec.h) from other targets
> > without getting cyclic dependencies.
> >
> > BUG=webrtc:6402,webrtc:6337
> >
> > NOTRY=True
> >
> > Committed: https://crrev.com/aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a
> > Cr-Commit-Position: refs/heads/master@{#15137}
>
> TBR=kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6402,webrtc:6337
>
> Committed: https://crrev.com/0d0d7531b50a78efe7468610395e9dc5f496e2e9
> Cr-Commit-Position: refs/heads/master@{#15139}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6402,webrtc:6337

Committed: https://crrev.com/0928a3cf0f0552bb0dc29f58bf8e86bd089cd215
Cr-Commit-Position: refs/heads/master@{#15235}
==========

[commit-bot: I haz the power, 2016-11-25 08:40:32]

Patchset 3 (id:??) landed as
https://crrev.com/0928a3cf0f0552bb0dc29f58bf8e86bd089cd215
Cr-Commit-Position: refs/heads/master@{#15235}