Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2508943004: Modify audio_processing_unittest to use ResourcePath instead of ProjectRootPath. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Modify audio_processing_unittest to use ResourcePath instead of ProjectRootPath. Move the resources to //resources and upload them to Google Storage. BUG=webrtc:6727 Committed: https://crrev.com/dedaf1ced7ed8fc7a1a304fd9a8176fd232f7a7c Cr-Commit-Position: refs/heads/master@{#15152}

Patch Set 1 #

Patch Set 2 : Remove unused //data dependencies. #

Total comments: 2

Patch Set 3 : Removed debug leftovers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
D data/audio_processing/output_data_fixed.pb View Binary file 0 comments Download
D data/audio_processing/output_data_float.pb View Binary file 0 comments Download
D data/audio_processing/output_data_mac.pb View Binary file 0 comments Download
A resources/audio_processing/output_data_fixed.pb.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A resources/audio_processing/output_data_float.pb.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A resources/audio_processing/output_data_mac.pb.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 1 2 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ehmaldonado_webrtc
4 years, 1 month ago (2016-11-17 16:31:42 UTC) #2
kjellander_webrtc
https://codereview.webrtc.org/2508943004/diff/20001/webrtc/modules/audio_processing/audio_processing_unittest.cc File webrtc/modules/audio_processing/audio_processing_unittest.cc (right): https://codereview.webrtc.org/2508943004/diff/20001/webrtc/modules/audio_processing/audio_processing_unittest.cc#newcode430 webrtc/modules/audio_processing/audio_processing_unittest.cc:430: fprintf(stderr, "ref_filename: %s\n", ref_filename_.c_str()); Please remove this. I think ...
4 years, 1 month ago (2016-11-17 16:40:31 UTC) #4
ehmaldonado_webrtc
https://codereview.webrtc.org/2508943004/diff/20001/webrtc/modules/audio_processing/audio_processing_unittest.cc File webrtc/modules/audio_processing/audio_processing_unittest.cc (right): https://codereview.webrtc.org/2508943004/diff/20001/webrtc/modules/audio_processing/audio_processing_unittest.cc#newcode430 webrtc/modules/audio_processing/audio_processing_unittest.cc:430: fprintf(stderr, "ref_filename: %s\n", ref_filename_.c_str()); On 2016/11/17 16:40:31, kjellander_webrtc wrote: ...
4 years, 1 month ago (2016-11-17 16:46:25 UTC) #5
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-11-17 16:48:23 UTC) #6
hlundin-webrtc
lgtm
4 years, 1 month ago (2016-11-18 12:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2508943004/40001
4 years, 1 month ago (2016-11-18 12:39:19 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-18 12:52:25 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 12:52:40 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dedaf1ced7ed8fc7a1a304fd9a8176fd232f7a7c
Cr-Commit-Position: refs/heads/master@{#15152}

Powered by Google App Engine
This is Rietveld 408576698