Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: webrtc/common_types.h

Issue 2508853002: Reland of Declare VideoCodec.codec_specific_info private (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/android/jni/androidmediaencoder_jni.cc ('k') | webrtc/common_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_types.h
diff --git a/webrtc/common_types.h b/webrtc/common_types.h
index 77c009cd9d807bf129ea6bc55ad1510d04f156a3..803f2c263221aed64964fee391869086a7d26f5c 100644
--- a/webrtc/common_types.h
+++ b/webrtc/common_types.h
@@ -637,11 +637,10 @@ class VideoCodec {
VideoCodecH264* H264();
const VideoCodecH264& H264() const;
- // This variable will be declared private and renamed to codec_specific_
- // once Chromium is not accessing it.
+ private:
// TODO(hta): Consider replacing the union with a pointer type.
// This will allow removing the VideoCodec* types from this file.
- VideoCodecUnion codecSpecific;
+ VideoCodecUnion codec_specific_;
};
class BitrateAllocation {
« no previous file with comments | « webrtc/api/android/jni/androidmediaencoder_jni.cc ('k') | webrtc/common_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698