Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2508163002: Revert of Split out target rtc_media_base from rtc_media (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Split out target rtc_media_base from rtc_media (patchset #3 id:40001 of https://codereview.webrtc.org/2471573003/ ) Reason for revert: Breaks downstream import. Original issue's description: > Split out target rtc_media_base from rtc_media > > The purpose with this CL is to be able to depend on > cricket::VideoCodec (webrtc/media/base/codec.h) from other targets > without getting cyclic dependencies. > > BUG=webrtc:6402, webrtc:6337 > > NOTRY=True > > Committed: https://crrev.com/aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a > Cr-Commit-Position: refs/heads/master@{#15137} TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6402, webrtc:6337 Committed: https://crrev.com/0d0d7531b50a78efe7468610395e9dc5f496e2e9 Cr-Commit-Position: refs/heads/master@{#15139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M webrtc/media/BUILD.gn View 4 chunks +3 lines, -35 lines 0 comments Download
M webrtc/media/base/codec.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
magjed_webrtc
Created Revert of Split out target rtc_media_base from rtc_media
4 years, 1 month ago (2016-11-17 15:51:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2508163002/1
4 years, 1 month ago (2016-11-17 15:51:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 15:51:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d0d7531b50a78efe7468610395e9dc5f496e2e9 Cr-Commit-Position: refs/heads/master@{#15139}
4 years, 1 month ago (2016-11-17 15:51:42 UTC) #6
magjed_webrtc
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2509123003/ by magjed@webrtc.org. ...
4 years, 1 month ago (2016-11-17 16:17:55 UTC) #7
kjellander_webrtc
4 years, 1 month ago (2016-11-17 16:33:03 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698