Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2507263003: Revert of MB: Run test with gtest-parallel on swarming. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of MB: Run test with gtest-parallel on swarming. (patchset #6 id:220001 of https://codereview.webrtc.org/2503503002/ ) Reason for revert: There might be a bug where only failures in the first shard are reported. This is an example of a clearly wrong CL that passes the tests: https://codereview.webrtc.org/2507713002/#ps60001 Original issue's description: > MB: Run test with gtest-parallel on swarming. > > TBR=pbos@webrtc.org > BUG=chromium:497757, chromium:664425 > NOTRY=True > > Committed: https://crrev.com/b2fcf6d96f4efdc7a606c1cc0f999932c63226d4 > Cr-Commit-Position: refs/heads/master@{#15093} TBR=kjellander@webrtc.org,pbos@webrtc.org NOTRY=True BUG=chromium:497757, chromium:664425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -35 lines) Patch
M third_party/gtest-parallel/gtest-parallel View 3 chunks +1 line, -12 lines 0 comments Download
M tools/mb/mb.py View 2 chunks +37 lines, -19 lines 0 comments Download
M tools/mb/mb_unittest.py View 3 chunks +29 lines, -3 lines 0 comments Download
M webrtc/build/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
ehmaldonado_webrtc
Created Revert of MB: Run test with gtest-parallel on swarming.
4 years, 1 month ago (2016-11-16 23:46:46 UTC) #1
ehmaldonado_webrtc
4 years, 1 month ago (2016-11-17 00:12:13 UTC) #4
On 2016/11/16 23:46:46, ehmaldonado_webrtc wrote:
> Created Revert of MB: Run test with gtest-parallel on swarming.

Figured out the bug. The fix will be landed instead:
https://codereview.webrtc.org/2505093003/

Powered by Google App Engine
This is Rietveld 408576698