Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2506603002: Add a JNI boot test to catch ARM dynamic linker regressions. (Closed)

Created:
4 years, 1 month ago by phoglund
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a JNI boot test to catch ARM dynamic linker regressions. The peer connection loopback test could catch regressions too, but it's too slow to run on downstream ARM emulators. I'm adding a test here that just makes sure we can load the JNI and init audio/video engines in WebRTC. This test overlaps in functionality with the existing tests, but we need it anyway since all existing tests are too timing-sensitive. Removes resources from the test; they're awkward downstream and we don't really need them anyway. BUG=b/32820229 Committed: https://crrev.com/613152af11d6e9a4d046af3c48a7be7642dfcc68 Cr-Commit-Position: refs/heads/master@{#15101}

Patch Set 1 #

Patch Set 2 : Moving test to peer connection tests. #

Total comments: 1

Messages

Total messages: 18 (10 generated)
phoglund
4 years, 1 month ago (2016-11-15 12:27:51 UTC) #2
perkj_webrtc
I will leave this to magjed to decide and review. But other pc tests are ...
4 years, 1 month ago (2016-11-15 14:58:49 UTC) #4
phoglund
On 2016/11/15 14:58:49, perkj_webrtc wrote: > I will leave this to magjed to decide and ...
4 years, 1 month ago (2016-11-15 15:41:55 UTC) #5
phoglund
PTAL https://codereview.webrtc.org/2506603002/diff/20001/webrtc/api/androidtests/AndroidManifest.xml File webrtc/api/androidtests/AndroidManifest.xml (right): https://codereview.webrtc.org/2506603002/diff/20001/webrtc/api/androidtests/AndroidManifest.xml#newcode25 webrtc/api/androidtests/AndroidManifest.xml:25: android:label="AndroidPeerconnectionTests" > Note: I got rid of the ...
4 years, 1 month ago (2016-11-15 15:55:39 UTC) #6
magjed_webrtc
lgtm
4 years, 1 month ago (2016-11-16 09:27:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506603002/20001
4 years, 1 month ago (2016-11-16 09:29:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 09:31:28 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 09:31:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/613152af11d6e9a4d046af3c48a7be7642dfcc68
Cr-Commit-Position: refs/heads/master@{#15101}

Powered by Google App Engine
This is Rietveld 408576698