webrtc/modules/audio_mixer/audio_mixer_impl.h - Issue 2506173003: Changed the interface AudioMixer::RemoveSource to have a void return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_mixer/audio_mixer_impl.h

Issue 2506173003: Changed the interface AudioMixer::RemoveSource to have a void return type. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_mixer/audio_mixer_impl.h

diff --git a/webrtc/modules/audio_mixer/audio_mixer_impl.h b/webrtc/modules/audio_mixer/audio_mixer_impl.h

index ec2989e55476adc8780ac6245055c2192943e842..af83367fc4ab10057c351c2d1a002220e5a940cc 100644

--- a/webrtc/modules/audio_mixer/audio_mixer_impl.h

+++ b/webrtc/modules/audio_mixer/audio_mixer_impl.h

@@ -53,7 +53,7 @@ class AudioMixerImpl : public AudioMixer {

// AudioMixer functions

bool AddSource(Source* audio_source) override;

- bool RemoveSource(Source* audio_source) override;

+ void RemoveSource(Source* audio_source) override;

void Mix(size_t number_of_channels,

AudioFrame* audio_frame_for_mixing) override LOCKS_EXCLUDED(crit_);