Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2505993002: Renamed -red to -ed and -red_graph to -ed_graph in audioproc_f. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed -red to -ed and -red_graph to -ed_graph in audioproc_f. The red acronym is already in use in the context of audio coding, so it is better to avoid reusing it here because it could be confusing. BUG=webrtc:6525 Committed: https://crrev.com/0bff12a63d64dac902c75e754a5ec0e00de130e8 Cr-Commit-Position: refs/heads/master@{#15121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M webrtc/modules/audio_processing/test/aec_dump_based_simulator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_simulator.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ivoc
Henrik, PTAL.
4 years, 1 month ago (2016-11-16 14:48:15 UTC) #3
hlundin-webrtc
lgtm
4 years, 1 month ago (2016-11-17 08:17:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505993002/1
4 years, 1 month ago (2016-11-17 08:37:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 08:55:46 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:55:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bff12a63d64dac902c75e754a5ec0e00de130e8
Cr-Commit-Position: refs/heads/master@{#15121}

Powered by Google App Engine
This is Rietveld 408576698