Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2505983002: Only enable residual echo detector when needed in level controller perf tests. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only enable residual echo detector when needed in level controller perf tests. BUG=webrtc:6525, chromium:665885 Committed: https://crrev.com/377b60ce110fcdb3f8e9b1ee8629a3371ac0af42 Cr-Commit-Position: refs/heads/master@{#15122}

Patch Set 1 : Only enable residual echo detector when needed in level controller perf tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/modules/audio_processing/level_controller/level_controller_complexity_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ivoc
Hi Henrik, this fix should only enable the residual echo detector in those level controller ...
4 years, 1 month ago (2016-11-16 14:36:02 UTC) #2
hlundin-webrtc
LGTM, but please, link to the perf bug too.
4 years, 1 month ago (2016-11-17 08:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2505983002/20001
4 years, 1 month ago (2016-11-17 08:39:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-17 09:04:20 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 09:04:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/377b60ce110fcdb3f8e9b1ee8629a3371ac0af42
Cr-Commit-Position: refs/heads/master@{#15122}

Powered by Google App Engine
This is Rietveld 408576698